From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932124AbdJXREJ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 13:04:09 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:45802 "EHLO
        mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751576AbdJXREE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 13:04:04 -0400
X-Google-Smtp-Source: ABhQp+QMESxRsu9wh4XU/tK6n5x68OtC+0ZesMia+5FzNPj+9wkqr/2VVu9uuk+tTsiJmrTnvFxZCw==
Date: Tue, 24 Oct 2017 10:03:56 -0700
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Manoj Gupta <manojgupta@chromium.org>,
        "David S . Miller" <davem@davemloft.net>,
        Simon Horman <simon.horman@netronome.com>,
        Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
        oss-drivers@netronome.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Renato Golin <renato.golin@linaro.org>,
        Guenter Roeck <groeck@chromium.org>,
        Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro
Message-ID: <20171024100356.63bcbb2f@cakuba.netronome.com>
In-Reply-To: <20171024165603.GA96615@google.com>
References: <20171003200546.165731-1-mka@chromium.org>
        <20171003145000.53683e21@cakuba>
        <CAAMbb05G=HBQweiWqYva_9zTnQqAcwMhJ0yYBUi26T04YA4CxQ@mail.gmail.com>
        <20171004111724.29a4d7ff@cakuba.netronome.com>
        <20171024165603.GA96615@google.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 24 Oct 2017 09:56:03 -0700, Matthias Kaehlcke wrote:
> > @@ -561,6 +568,6 @@ int __nfp_eth_set_speed(struct nfp_nsp *nsp, unsigned int speed)
> >   */
> >  int __nfp_eth_set_split(struct nfp_nsp *nsp, unsigned int lanes)
> >  {
> > -	return nfp_eth_set_bit_config(nsp, NSP_ETH_RAW_PORT, NSP_ETH_PORT_LANES,
> > +	return NFP_ETH_SET_BIT_CONFIG(nsp, NSP_ETH_RAW_PORT, NSP_ETH_PORT_LANES,
> >  				      lanes, NSP_ETH_CTRL_SET_LANES);
> >  }  
> 
> Do you plan to send this as an official patch?

Sorry...  Dirk is prepping a larger series for this area of code and it
got stuck there a bit :S  He says it's coming any day now...