Re: [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion()

Ingo Molnar
2017-10-25T05:55:35Z

* Byungchul Park <byungchul.park@lge.com> wrote:

> > Isn't lockdep_map a zero size structure that is always defined? If yes then
> > there's no need for an #ifdef.
>
> No, a zero size structure for lockdep_map is not provided yet.
> There are two options I can do:
>
> 1. Add a zero size structure for lockdep_map and remove #ifdef
> 2. Replace CONFIG_LOCKDEP_COMPLETIONS with CONFIG_LOCKDEP here.
>
> Or something else?
>
> Which one do you prefer?

Ok, could we try #1 in a new patch and re-spin the simplified block layer patch on
top of that?

The less ugly a debug facility's impact on unrelated kernel is, the better -
especially when it comes to annotating false positives.

Thanks,

Ingo