From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751491AbdJXOg6 (ORCPT ); Tue, 24 Oct 2017 10:36:58 -0400 Received: from mga11.intel.com ([192.55.52.93]:64283 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdJXOgz (ORCPT ); Tue, 24 Oct 2017 10:36:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,428,1503385200"; d="scan'208";a="166451479" Date: Tue, 24 Oct 2017 20:11:18 +0530 From: Vinod Koul To: Kees Cook Cc: Dan Williams , Dave Jiang , Ujjal Singh , Pan Bian , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: Convert timers to use timer_setup() Message-ID: <20171024144117.GS936@localhost> References: <20171024100223.GA68045@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024100223.GA68045@beast> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 03:02:23AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Would have preferd patch per driver. > Cc: Vinod Koul > Cc: Dan Williams > Cc: Dave Jiang > Cc: Ujjal Singh > Cc: Pan Bian > Cc: dmaengine@vger.kernel.org This is pretty useless for the log. i prefer adding this after s-o-b line so that it doesn't get carried while applying > Signed-off-by: Kees Cook Applied now, thanks -- ~Vinod