From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932315AbdJXPOE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 11:14:04 -0400
Received: from mail-wr0-f180.google.com ([209.85.128.180]:49186 "EHLO
        mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751504AbdJXPOB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 11:14:01 -0400
X-Google-Smtp-Source: ABhQp+TSPXNCuN/kxMOV7IuVYlUbjr9z1ndnshDeOIkb9jGsc1M2bS19Tb9ku7dw5pDlsAziEv++CQ==
X-Google-Original-Sender: <johan@kernel.org>
Date: Tue, 24 Oct 2017 17:13:25 +0200
From: Johan Hovold <johan@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Johan Hovold <johan@kernel.org>,
        Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-kernel@vger.kernel.org, cphealy@gmail.com,
        Lucas Stach <l.stach@pengutronix.de>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Lee Jones <lee.jones@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory
 Processor
Message-ID: <20171024151325.GA13452@localhost>
References: <20171013061321.31252-1-andrew.smirnov@gmail.com>
 <20171013061321.31252-2-andrew.smirnov@gmail.com>
 <20171013072731.GC29243@localhost>
 <20171023093054.GG32228@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171023093054.GG32228@amd>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 23, 2017 at 11:30:54AM +0200, Pavel Machek wrote:
> Hi!
> 
> > >  drivers/platform/Kconfig        |   2 +
> > >  drivers/platform/Makefile       |   1 +
> > >  drivers/platform/rave/Kconfig   |  26 ++
> > >  drivers/platform/rave/Makefile  |   1 +
> > >  drivers/platform/rave/rave-sp.c | 677 ++++++++++++++++++++++++++++++++++++++++
> > 
> > First of all, why do these live in drivers/platform and why don't use
> > the mfd subsystem to implement this driver (instead of rolling your own
> > mfd-implementation)?
> 
> Sending contributors around like this is quite uncool.

Asking questions when things are done in unexpected ways is part of the
review process, and the backstory here wasn't documented in the patch or
cover letter.

> 1st, it should not matter much in which directory the driver lives.
> 
> 2nd, there's no reasonable way for contributor to proceed if he gets
> "stuck" between two maintainers.
> 
> Can you discuss with MFD maintainers, and provide clear guidance?

Seems we all agree this driver belongs in mfd now.

Johan