From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdJXQYb (ORCPT ); Tue, 24 Oct 2017 12:24:31 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.163]:42365 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbdJXQY3 (ORCPT ); Tue, 24 Oct 2017 12:24:29 -0400 Date: Tue, 24 Oct 2017 11:24:27 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] rxrpc: key: use BUG_ON instead of if condition followed by BUG Message-ID: <20171024162427.GA29478@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Exim-ID: 1e720C-003uX2-5A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:53076 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 12 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use BUG_ON instead of if condition followed by BUG. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/rxrpc/key.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index e7f6b88..b7cc1b1 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -851,8 +851,7 @@ static int rxrpc_preparse_s(struct key_preparsed_payload *prep) return PTR_ERR(ci); } - if (crypto_skcipher_setkey(ci, prep->data, 8) < 0) - BUG(); + BUG_ON(crypto_skcipher_setkey(ci, prep->data, 8) < 0); prep->payload.data[0] = ci; _leave(" = 0"); -- 2.7.4