Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

Byungchul Park
2017-05-30T05:30:00Z

On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

+to peterz@infradead.org
+to mingo@kernel.org
+to rostedt@goodmis.org

I am not sure whom should I send this patch to..
Could you check this if you are right person?

>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> kernel/irq_work.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index bcf107c..e2ebe8c 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
> return;
>
> llnode = llist_del_all(list);
> - while (llnode != NULL) {
> - work = llist_entry(llnode, struct irq_work, llnode);
> -
> - llnode = llist_next(llnode);
> -
> + llist_for_each_entry(work, llnode, llnode) {
> /*
> * Clear the PENDING bit, after this point the @work
> * can be re-used.
> --
> 1.9.1