From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
Sherry Yang <sherryy@android.com>,
LKML <linux-kernel@vger.kernel.org>,
Riley Andrews <riandrews@android.com>,
Martijn Coenen <maco@google.com>, Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task
Date: Wed, 25 Oct 2017 09:11:19 +0200 [thread overview]
Message-ID: <20171025071119.GA16135@kroah.com> (raw)
In-Reply-To: <CAMP5XgcHj_LtPW2dYGVo2Lj2+9HOTjzSVBk2xiRu9g_bz2b1Yw@mail.gmail.com>
On Tue, Oct 24, 2017 at 11:36:48AM -0700, Arve Hjønnevåg wrote:
> On Tue, Oct 24, 2017 at 12:28 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Mon, Oct 23, 2017 at 11:18:52AM -0700, Arve Hjønnevåg wrote:
> >> On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman
> >> <gregkh@linuxfoundation.org> wrote:
> >> > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote:
> >> >> Use binder_alloc struct's mm_struct rather than getting
> >> >> a reference to the mm struct through get_task_mm to
> >> >> avoid a potential deadlock between lru lock, task lock and
> >> >> dentry lock, since a thread can be holding the task lock
> >> >> and the dentry lock while trying to acquire the lru lock.
> >> >>
> >> >> Acked-by: Arve Hjønnevåg <arve@android.com>
> >> >> Signed-off-by: Sherry Yang <sherryy@android.com>
> >> >> ---
> >> >> drivers/android/binder_alloc.c | 22 +++++++++-------------
> >> >> drivers/android/binder_alloc.h | 1 -
> >> >> 2 files changed, 9 insertions(+), 14 deletions(-)
> >> >
> >> > I've applied these first 2 patches, but patches 3 and 4 I have already
> >> > applied to my char-misc-next tree, right?
> >> >
> >> > thanks,
> >> >
> >> > greg k-h
> >>
> >> I would expect you got a merge conflict from one of those. Using patch
> >> 3 and 4 in from this patchset should avoid that conflict if your
> >> eventual 4.15 branch is not based on your current char-misc-next
> >> branch.
> >
> > I've resolved the merge conflict so my char-misc-next branch should be
> > all caught up now. It would be wonderful if you could verify this.
> >
> > thanks,
> >
> > greg k-h
>
> I have not tested your branch directly, but the relevant code in
> char-misc-next is now identical to the code I tested.
Wonderful, thanks for verifying.
greg k-h
next prev parent reply other threads:[~2017-10-25 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 0:58 [PATCH v2 0/4] android: binder: fixes for memory allocator change Sherry Yang
2017-10-21 0:58 ` [PATCH v2 1/4] android: binder: Don't get mm from task Sherry Yang
2017-10-21 8:15 ` Greg Kroah-Hartman
2017-10-23 18:18 ` Arve Hjønnevåg
2017-10-24 7:28 ` Greg Kroah-Hartman
2017-10-24 18:36 ` Arve Hjønnevåg
2017-10-25 7:11 ` Greg Kroah-Hartman [this message]
2017-10-21 0:58 ` [PATCH v2 2/4] android: binder: Fix null ptr dereference in debug msg Sherry Yang
2017-10-21 0:59 ` [PATCH v2 3/4] android: binder: Remove unused vma argument Sherry Yang
2017-10-21 0:59 ` [PATCH v2 4/4] android: binder: Change binder_shrinker to static Sherry Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025071119.GA16135@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=riandrews@android.com \
--cc=sherryy@android.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox