From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932491AbdJYI7e (ORCPT ); Wed, 25 Oct 2017 04:59:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41224 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932217AbdJYI72 (ORCPT ); Wed, 25 Oct 2017 04:59:28 -0400 Date: Wed, 25 Oct 2017 09:11:19 +0200 From: Greg Kroah-Hartman To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: "open list:ANDROID DRIVERS" , Sherry Yang , LKML , Riley Andrews , Martijn Coenen , Todd Kjos Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task Message-ID: <20171025071119.GA16135@kroah.com> References: <20171021005902.59586-1-sherryy@android.com> <20171021005902.59586-2-sherryy@android.com> <20171021081513.GA19354@kroah.com> <20171024072847.GA6034@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 11:36:48AM -0700, Arve Hjønnevåg wrote: > On Tue, Oct 24, 2017 at 12:28 AM, Greg Kroah-Hartman > wrote: > > On Mon, Oct 23, 2017 at 11:18:52AM -0700, Arve Hjønnevåg wrote: > >> On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman > >> wrote: > >> > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: > >> >> Use binder_alloc struct's mm_struct rather than getting > >> >> a reference to the mm struct through get_task_mm to > >> >> avoid a potential deadlock between lru lock, task lock and > >> >> dentry lock, since a thread can be holding the task lock > >> >> and the dentry lock while trying to acquire the lru lock. > >> >> > >> >> Acked-by: Arve Hjønnevåg > >> >> Signed-off-by: Sherry Yang > >> >> --- > >> >> drivers/android/binder_alloc.c | 22 +++++++++------------- > >> >> drivers/android/binder_alloc.h | 1 - > >> >> 2 files changed, 9 insertions(+), 14 deletions(-) > >> > > >> > I've applied these first 2 patches, but patches 3 and 4 I have already > >> > applied to my char-misc-next tree, right? > >> > > >> > thanks, > >> > > >> > greg k-h > >> > >> I would expect you got a merge conflict from one of those. Using patch > >> 3 and 4 in from this patchset should avoid that conflict if your > >> eventual 4.15 branch is not based on your current char-misc-next > >> branch. > > > > I've resolved the merge conflict so my char-misc-next branch should be > > all caught up now. It would be wonderful if you could verify this. > > > > thanks, > > > > greg k-h > > I have not tested your branch directly, but the relevant code in > char-misc-next is now identical to the code I tested. Wonderful, thanks for verifying. greg k-h