From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Milian Wolff <milian.wolff@kdab.com>
Subject: Re: [PATCH] perf callchain: Pass relative address to hist entry
Date: Wed, 25 Oct 2017 10:34:32 +0200 [thread overview]
Message-ID: <20171025083432.GE22394@krava> (raw)
In-Reply-To: <20171025021209.13180-1-namhyung@kernel.org>
On Wed, Oct 25, 2017 at 11:12:09AM +0900, Namhyung Kim wrote:
> The addr_location->addr should have relative address to be passed to
> hist entry so that it can compare with others which might come from a
> different address space.
>
> The callchain_cursor_node->ip already has a relative address thus it
> should not map it again. But I found a bug handling cumulative
> (children) entries. For chilren entries that has no self period, the
> al->addr (so he->ip) ends up having an doubly-mapped address.
>
> It seems to be there from the beginning but only affects entries that
> have no srclines - finding srcline itself is done using a different
> address but it will show the invalid address if no srcline was found.
>
> Tested-by: Milian Wolff <milian.wolff@kdab.com>
> Fixes: c7405d85d7a3 ("perf tools: Update cpumode for each cumulative entry")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
hum, I'm getting differences in hist entries for:
$ perf record --all-user -ga sleep 1
$ perf perf report --stdio > ...
...
$ diff -puw /tmp/o.old /tmp/o.new
jirka
---
@@ -51,7 +51,7 @@
|
--0.94%--0x3
- 3.38% 0.00% Web Content libxul.so [.] 0xffff8087f8e046a5
+ 3.38% 0.00% Web Content libxul.so [.] 0x00000000031c16a5
|
---0x31c16a5
|
@@ -91,7 +91,7 @@
|
--1.62%--malloc
- 2.47% 0.00% Compositor libxul.so [.] 0xffff80e6f2807790
+ 2.47% 0.00% Compositor libxul.so [.] 0x0000000000b9b790
|
---0xb9b790
|
@@ -163,7 +163,7 @@
|
---0x72be62f5fdc55d00
- 1.05% 0.00% Compositor libxul.so [.] 0xffff80e6f280f100
+ 1.05% 0.00% Compositor libxul.so [.] 0x0000000000ba3100
|
---0xba3100
|
next prev parent reply other threads:[~2017-10-25 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 2:12 [PATCH] perf callchain: Pass relative address to hist entry Namhyung Kim
2017-10-25 8:34 ` Jiri Olsa [this message]
2017-10-25 8:48 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025083432.GE22394@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox