From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbdJYIek (ORCPT ); Wed, 25 Oct 2017 04:34:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55768 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbdJYIeg (ORCPT ); Wed, 25 Oct 2017 04:34:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 28F76883D4 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 25 Oct 2017 10:34:32 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, Milian Wolff Subject: Re: [PATCH] perf callchain: Pass relative address to hist entry Message-ID: <20171025083432.GE22394@krava> References: <20171025021209.13180-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171025021209.13180-1-namhyung@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 25 Oct 2017 08:34:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2017 at 11:12:09AM +0900, Namhyung Kim wrote: > The addr_location->addr should have relative address to be passed to > hist entry so that it can compare with others which might come from a > different address space. > > The callchain_cursor_node->ip already has a relative address thus it > should not map it again. But I found a bug handling cumulative > (children) entries. For chilren entries that has no self period, the > al->addr (so he->ip) ends up having an doubly-mapped address. > > It seems to be there from the beginning but only affects entries that > have no srclines - finding srcline itself is done using a different > address but it will show the invalid address if no srcline was found. > > Tested-by: Milian Wolff > Fixes: c7405d85d7a3 ("perf tools: Update cpumode for each cumulative entry") > Signed-off-by: Namhyung Kim hum, I'm getting differences in hist entries for: $ perf record --all-user -ga sleep 1 $ perf perf report --stdio > ... ... $ diff -puw /tmp/o.old /tmp/o.new jirka --- @@ -51,7 +51,7 @@ | --0.94%--0x3 - 3.38% 0.00% Web Content libxul.so [.] 0xffff8087f8e046a5 + 3.38% 0.00% Web Content libxul.so [.] 0x00000000031c16a5 | ---0x31c16a5 | @@ -91,7 +91,7 @@ | --1.62%--malloc - 2.47% 0.00% Compositor libxul.so [.] 0xffff80e6f2807790 + 2.47% 0.00% Compositor libxul.so [.] 0x0000000000b9b790 | ---0xb9b790 | @@ -163,7 +163,7 @@ | ---0x72be62f5fdc55d00 - 1.05% 0.00% Compositor libxul.so [.] 0xffff80e6f280f100 + 1.05% 0.00% Compositor libxul.so [.] 0x0000000000ba3100 | ---0xba3100 |