From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751833AbdJYOHk (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 10:07:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53314 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751374AbdJYOHf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 10:07:35 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 053ED8211D
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com
Date: Wed, 25 Oct 2017 16:07:31 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andi Kleen <andi@firstfloor.org>, "Jin, Yao" <yao.jin@linux.intel.com>,
        "Wangnan (F)" <wangnan0@huawei.com>,
        "Du, Changbin" <changbin.du@intel.com>
Subject: Re: [PATCHv2 9/9] perf tools: Unwind properly location after REJECT
Message-ID: <20171025140731.GB30082@krava>
References: <20171013083736.15037-1-jolsa@kernel.org>
 <20171013083736.15037-10-jolsa@kernel.org>
 <20171013195036.GB5311@kernel.org>
 <20171024125121.GA5191@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171024125121.GA5191@krava>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 25 Oct 2017 14:07:35 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 24, 2017 at 02:51:21PM +0200, Jiri Olsa wrote:
> On Fri, Oct 13, 2017 at 04:50:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 13, 2017 at 10:37:36AM +0200, Jiri Olsa escreveu:
> > > We have defined YY_USER_ACTION to keep trace of the column
> > > location during events parsing, but we need to clean it up
> > > when we call REJECT.
> > > 
> > > When REJECT is called, the lexer shrinks the text and re-runs
> > > the matching, so we need to address it in resuming the previous
> > > location value.
> > 
> > What is this fixing? Please state that, below I show what it is breaking
> > :-/
> > 
> > Before:
> > 
> > [root@jouet ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
> > bpf: builtin compilation failed: -95, try external compiler
> >      0.000 perf_bpf_probe:func:(ffffffffbb2634e0))
> >                                        sys_read ([kernel.kallsyms])
> >                                        entry_SYSCALL_64_fastpath ([kernel.kallsyms])
> >                                        __read (/usr/lib64/ld-2.25.so)
> >                                        _dl_map_object (/usr/lib64/ld-2.25.so)
> > 
> > After:
> > 
> > [root@jouet ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
> > event syntax error: '/home/acme/bpf/sys_read.c/max-stack=5/'
> >                      \___ parser error
> > Run 'perf list' for a list of valid events
> > 
> >  Usage: perf trace [<options>] [<command>]
> >     or: perf trace [<options>] -- <command> [<options>]
> >     or: perf trace record [<options>] [<command>]
> >     or: perf trace record [<options>] -- <command> [<options>]
> > 
> >     -e, --event <event>   event/syscall selector. use 'perf list' to list available events
> > [root@jouet ~]# 
> > 
> 
> v2 with updated changelog attached,
> 
> also I rebased the rest of the fixes and pushed
> them into perf/fixes branch

and I just rebased/pushed that once again.. we are too fast ;-)

thanks,
jirka