From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbdJZE2S (ORCPT ); Thu, 26 Oct 2017 00:28:18 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:52893 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdJZE2P (ORCPT ); Thu, 26 Oct 2017 00:28:15 -0400 X-Google-Smtp-Source: ABhQp+TvCEG14KiaEXhs/j2l2bDlKACBzxW9WxPHsveLUH6pA8q963Uq4qlclStBHaNX/+WF9gFirw== Date: Wed, 25 Oct 2017 21:28:11 -0700 From: Bjorn Andersson To: Georgi Djakov Cc: sboyd@codeaurora.org, jassisinghbrar@gmail.com, robh+dt@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a separate header Message-ID: <20171026042811.GL1575@tuxbook> References: <20170921164940.20343-1-georgi.djakov@linaro.org> <20170921164940.20343-4-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170921164940.20343-4-georgi.djakov@linaro.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote: > Move the structure shared by the APCS IPC device and its subdevices > into a separate header file. > As you're creating the apcs regmap with devm_regmap_init_mmio() you can just call dev_get_regmap(dev->parent) in your child to get the handle. But I would prefer that you just add the clock code to the existing driver. Regards, Bjorn