public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: LABBE Corentin <clabbe@baylibre.com>
To: mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint
Date: Thu, 26 Oct 2017 14:20:55 +0200	[thread overview]
Message-ID: <20171026122055.GB26709@Red> (raw)
In-Reply-To: <1509019317-40116-1-git-send-email-clabbe@baylibre.com>

On Thu, Oct 26, 2017 at 12:01:54PM +0000, Corentin Labbe wrote:
> This patch fix the following build warnings:
> drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  drivers/usb/host/xhci.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index ee077a2..b12b2bd 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -3375,7 +3375,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  	unsigned int slot_id;
>  	struct xhci_virt_device *virt_dev;
>  	struct xhci_command *reset_device_cmd;
> -	int last_freed_endpoint;
>  	struct xhci_slot_ctx *slot_ctx;
>  	int old_active_eps = 0;
>  
> @@ -3490,7 +3489,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  	}
>  
>  	/* Everything but endpoint 0 is disabled, so free the rings. */
> -	last_freed_endpoint = 1;
>  	for (i = 1; i < 31; i++) {
>  		struct xhci_virt_ep *ep = &virt_dev->eps[i];
>  
> @@ -3505,7 +3503,6 @@ static int xhci_discover_or_reset_device(struct usb_hcd *hcd,
>  		if (ep->ring) {
>  			xhci_debugfs_remove_endpoint(xhci, virt_dev, i);
>  			xhci_free_endpoint_ring(xhci, virt_dev, i);
> -			last_freed_endpoint = i;
>  		}
>  		if (!list_empty(&virt_dev->eps[i].bw_endpoint_list))
>  			xhci_drop_ep_from_interval_table(xhci,
> -- 
> 2.7.4
> 

I apologize, I have make some mistake in my send.

Sorry

Regards

      parent reply	other threads:[~2017-10-26 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 12:01 [PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint Corentin Labbe
2017-10-26 12:01 ` [PATCH 2/4] usb: xhci: remove unused variable ep Corentin Labbe
2017-10-26 12:01 ` [PATCH 3/4] usb: xhci: remove unused variable urb_priv Corentin Labbe
2017-10-26 12:01 ` [PATCH 4/4] usb: xhci: remove unused variable ep_ring Corentin Labbe
2017-10-26 12:20 ` LABBE Corentin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026122055.GB26709@Red \
    --to=clabbe@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox