From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: <Mario.Limonciello@dell.com>
Cc: <acelan.kao@canonical.com>, <dvhart@infradead.org>,
<andy@infradead.org>, <linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO
Date: Thu, 26 Oct 2017 17:10:11 +0100 [thread overview]
Message-ID: <20171026171011.3eca122e@alans-desktop> (raw)
In-Reply-To: <08add166d5b34992ba167a878ca2a808@ausx13mpc124.AMER.DELL.COM>
> > +static int __init dell_uart_bl_init(void)
> > +{
> > + ftty = filp_open("/dev/ttyS0", O_RDWR | O_NOCTTY | O_NDELAY, 0);
>
You have no idea what name is assigned. This doesn't work.
This isn't the way to do it any more because the 'tty from kernel'
problem finally got fixed. You can attach it as a serdev directly to the
kernel.
Take a look at serdev_tty_port_register/serdev_tty_port_unreg
Alan
next prev parent reply other threads:[~2017-10-26 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 7:53 [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO AceLan Kao
2017-10-26 15:54 ` Mario.Limonciello
2017-10-26 16:10 ` Alan Cox [this message]
2017-10-27 2:21 ` AceLan Kao
2017-10-27 2:15 ` AceLan Kao
2017-10-27 15:52 ` Mario.Limonciello
2017-10-27 20:23 ` Andy Shevchenko
2017-10-27 10:24 ` Daniel Thompson
2017-10-27 20:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026171011.3eca122e@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=Mario.Limonciello@dell.com \
--cc=acelan.kao@canonical.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox