From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbdJ0GKq (ORCPT ); Fri, 27 Oct 2017 02:10:46 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:17563 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbdJ0GKl (ORCPT ); Fri, 27 Oct 2017 02:10:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171027061040epoutp031c9113653261317094a13d0ff0100392~xWHwTXUy90730107301epoutp03J X-AuditID: b6c32a45-333ff70000001129-30-59f2cddf570e Date: Fri, 27 Oct 2017 15:11:07 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Andi Shyti , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich Subject: Re: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group Message-id: <20171027061107.GC29398@gangnam> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20170929233212.GB14362@dtor-ws> User-Agent: Mutt/1.9.1 (2017-09-22) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAKsWRmVeSWpSXmKPExsWy7bCmue79s58iDR7P0rNY/OM5k8XhRS8Y LW5++sZqcXnXHDaLCYc3szuwery66uhxfcknZo+ds+6ye3zeJBfAEpVqk5GamJJapJCal5yf kpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0VkmhLDGnFCgUkFhcrKRvZ1OU X1qSqpCRX1xiqxRtaGikZ2hgrmdkZKRnYhxrZWQKVJKQmvF2jVXBVK6KyZf3szcwbuDoYuTk kBAwkWhtWcDaxcjFISSwg1Gi7dEMdgjnO6PEnc6DLDBVLadbGCESuxklrv28CtXyklGi+89e sCoWAVWJ7Q8mMoPYbAKaEk23f7CB2CIC+hLbZ/8C62YWmMQoMXvTRyCHg0NYwEdi7URGkBpe AR2JvfMOsUDYghI/Jt8Ds5mB4mePrWOEsKUlHv0FOY+Tg1NAV+LdpYdMILaogLLE3r5DYGdL CKxgk9j46wgTxNkuEpOamqFeEJZ4dXwLO4QtLfFs1UZGiIZmRokN2y4zQTgtjBK/X15lg6gy ljjV1cgEsZpPouPwX3aQqyUEeCU62oQgSjwkXr1czwYRdpTY/aIWJCwkcI1RYnObzwRG2VlI /pmF5J9ZSP5ZwMi8ilEstaA4Nz212KjAUK84Mbe4NC9dLzk/dxMjOHVpue5gnHHO5xCjAAej Eg/vCs1PkUKsiWXFlbmHGCU4mJVEeI2OAYV4UxIrq1KL8uOLSnNSiw8xmgLjZCKzlGhyPjCt 5pXEG5pYGpiYmRmZm1kAU5U4b/22axFCAumJJanZqakFqUUwfUwcnFINjJG/DLsvh5zuimIw j1QK9g342BB+WcaZwX7Wq7PJD9s4GVXfX7Yx63OPeD+zYH7HxdL2pn6Zz64tK/I5PLRPvH3R /9yJceuFPQnxl+4IK9wW9gzskd5+uXECp2DkdGO91D0/U5p7ZF6e0Dj5LCRYx0rdsc/du8R4 8qN2qesh06t9tObpTmpXYinOSDTUYi4qTgQA88gALXMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t9jAd37Zz9FGuzcJ2mx+MdzJovDi14w Wtz89I3V4vKuOWwWEw5vZndg9Xh11dHj+pJPzB47Z91l9/i8SS6AJYrLJiU1J7MstUjfLoEr 4+0aq4KpXBWTL+9nb2DcwNHFyMkhIWAi0XK6hbGLkYtDSGAno8St3VvYIZyXjBIdNw4xgVSx CKhKbH8wkRnEZhPQlGi6/YMNxBYR0JfYPvsXWDezwARGiYm7LwMVcXAIC/hIrJ3ICFLDK6Aj sXfeIRaIodcYJS4+vswCkRCU+DH5HpjNLKAlsX7ncSYIW1ri0d8Z7CA2p4CuxLtLD8HiogLK Env7DrFPYOSfhaR9FpL2WUjaFzAyr2KUTC0ozk3PLTYqMMpLLdcrTswtLs1L10vOz93ECAzb bYe1+ncwPl4Sf4hRgINRiYd3heanSCHWxLLiytxDjBIczEoivEbHgEK8KYmVValF+fFFpTmp xYcYpTlYlMR5+fOPRQoJpCeWpGanphakFsFkmTg4pRoY0w9xhUtK3M3N9/NV8pG+91fpTOKU 5rbHNht2fSvYPmVR1NvbzluPTJELPfRZ7EvzbLcD22/1VF7ZMc9sh1RATp9/pefD1LxDxcyF zEdutHyR87mm//xrV+XLx8rXlhh8d6i/k75P2C6277rUI+vew38q0hxea77JmZd28NSJG9P/ ccXeVov/qMRSnJFoqMVcVJwIAHVlN51XAgAA X-CMS-MailID: 20171027061039epcas2p38169d833a216a78c2b97316db99e677d X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170929233218epcas5p2b27950ed7f0765f864ec181ad0c67db9 X-RootMTR: 20170929233218epcas5p2b27950ed7f0765f864ec181ad0c67db9 References: <20170929203839.7010-1-andi@etezian.org> <20170929203839.7010-2-andi@etezian.org> <20170929233212.GB14362@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, > > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > > and friends") has added the the managed version for creating > > sysfs group files. > > > > Use devm_device_add_group instead of sysfs_create_group and > > remove the relative sysfs_remove_group and goto label. > > > > CC: Michael Hennerich > > Signed-off-by: Andi Shyti > > --- > > drivers/input/touchscreen/ad7877.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c > > index 9c250ae780d9..677ba38b4d1c 100644 > > --- a/drivers/input/touchscreen/ad7877.c > > +++ b/drivers/input/touchscreen/ad7877.c > > @@ -783,18 +783,16 @@ static int ad7877_probe(struct spi_device *spi) > > goto err_free_mem; > > } > > > > - err = sysfs_create_group(&spi->dev.kobj, &ad7877_attr_group); > > + err = devm_device_add_group(&spi->dev, &ad7877_attr_group); > > This changes order of operations and ultimately may cause use-after-free > as memory for ad7877 structure will be freed before we remove > attributes. yes, right... sorry... was too fast at making these patches :) I'll send a second version over the weekend. Andi