From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbdJ0ICK (ORCPT ); Fri, 27 Oct 2017 04:02:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39792 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdJ0IBu (ORCPT ); Fri, 27 Oct 2017 04:01:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7FDCF6034E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [V2] bcma: Use bcma_debug and not pr_cont in MIPS driver From: Kalle Valo In-Reply-To: References: To: Joe Perches Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Hauke Mehrtens , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20171027080150.60B1C6034E@smtp.codeaurora.org> Date: Fri, 27 Oct 2017 08:01:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver") > converted a printk(KERN_DEBUG to bcma_debug. > > bcma_debug is guarded by a #define DEBUG via pr_debug. > > This means that the bcma_debug will generally not be emitted > but any pr_cont following the bcma_debug will be emitted. > > Correct this by removing the uses of pr_cont by using a temporary. > > Signed-off-by: Joe Perches Patch applied to wireless-drivers-next.git, thanks. 758f7e06063a bcma: Use bcma_debug and not pr_cont in MIPS driver -- https://patchwork.kernel.org/patch/10016013/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches