* [PATCH] usb: musb_core: mark expected switch fall-through @ 2017-10-24 3:10 Gustavo A. R. Silva 2017-10-27 16:44 ` Bin Liu 0 siblings, 1 reply; 6+ messages in thread From: Gustavo A. R. Silva @ 2017-10-24 3:10 UTC (permalink / raw) To: Bin Liu, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel, Gustavo A. R. Silva In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1397608 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index ff5a1a8..889ca9b 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -767,6 +767,7 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb, case OTG_STATE_B_IDLE: if (!musb->is_active) break; + /* fall through */ case OTG_STATE_B_PERIPHERAL: musb_g_suspend(musb); musb->is_active = musb->g.b_hnp_enable; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb_core: mark expected switch fall-through 2017-10-24 3:10 [PATCH] usb: musb_core: mark expected switch fall-through Gustavo A. R. Silva @ 2017-10-27 16:44 ` Bin Liu 2017-10-27 16:49 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Bin Liu @ 2017-10-27 16:44 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel Hi, On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1397608 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Applied with the above Coverity-ID message removed. Thanks, -Bin. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb_core: mark expected switch fall-through 2017-10-27 16:44 ` Bin Liu @ 2017-10-27 16:49 ` Greg Kroah-Hartman 2017-10-27 16:56 ` Bin Liu 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2017-10-27 16:49 UTC (permalink / raw) To: Bin Liu, Gustavo A. R. Silva, linux-usb, linux-kernel On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > Hi, > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Addresses-Coverity-ID: 1397608 > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > Applied with the above Coverity-ID message removed. Why? It's good to track these things. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb_core: mark expected switch fall-through 2017-10-27 16:49 ` Greg Kroah-Hartman @ 2017-10-27 16:56 ` Bin Liu 2017-10-30 8:51 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Bin Liu @ 2017-10-27 16:56 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Gustavo A. R. Silva, linux-usb, linux-kernel On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > Hi, > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > Addresses-Coverity-ID: 1397608 > > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > > > Applied with the above Coverity-ID message removed. > > Why? It's good to track these things. hmm, I thought we don't want non-kernel related information in the commit message. I just sent the musb v4.15-rc1 patches to you. Do you want to resend them with this message adding back? Regards, -Bin. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb_core: mark expected switch fall-through 2017-10-27 16:56 ` Bin Liu @ 2017-10-30 8:51 ` Greg Kroah-Hartman 2017-10-30 13:18 ` Bin Liu 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2017-10-30 8:51 UTC (permalink / raw) To: Bin Liu, Gustavo A. R. Silva, linux-usb, linux-kernel On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote: > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > > Hi, > > > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > > where we are expecting to fall through. > > > > > > > > Addresses-Coverity-ID: 1397608 > > > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > > > > > Applied with the above Coverity-ID message removed. > > > > Why? It's good to track these things. > > hmm, I thought we don't want non-kernel related information in the commit > message. This is kernel-related information. We don't want foolish "Id:" lines, from gerrit instances, as they are no help at all because we can not do anything with them. We _do_ want identifiers that are globally unique that provide real information, like public bugzilla ids, and tools like coverity. So for things like this, always keep them on. I've added it back by hand now. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb_core: mark expected switch fall-through 2017-10-30 8:51 ` Greg Kroah-Hartman @ 2017-10-30 13:18 ` Bin Liu 0 siblings, 0 replies; 6+ messages in thread From: Bin Liu @ 2017-10-30 13:18 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Gustavo A. R. Silva, linux-usb, linux-kernel On Mon, Oct 30, 2017 at 09:51:18AM +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote: > > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > > > Hi, > > > > > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > > > where we are expecting to fall through. > > > > > > > > > > Addresses-Coverity-ID: 1397608 > > > > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > > > > > > > Applied with the above Coverity-ID message removed. > > > > > > Why? It's good to track these things. > > > > hmm, I thought we don't want non-kernel related information in the commit > > message. > > This is kernel-related information. > > We don't want foolish "Id:" lines, from gerrit instances, as they are no > help at all because we can not do anything with them. > > We _do_ want identifiers that are globally unique that provide real > information, like public bugzilla ids, and tools like coverity. So for > things like this, always keep them on. Thanks for clarifying this. > > I've added it back by hand now. Thanks, -Bin. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-30 13:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-24 3:10 [PATCH] usb: musb_core: mark expected switch fall-through Gustavo A. R. Silva 2017-10-27 16:44 ` Bin Liu 2017-10-27 16:49 ` Greg Kroah-Hartman 2017-10-27 16:56 ` Bin Liu 2017-10-30 8:51 ` Greg Kroah-Hartman 2017-10-30 13:18 ` Bin Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox