Re: [PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings

Ricardo Neri
2017-10-20T18:25:51Z

On Fri, Oct 20, 2017 at 07:12:30PM +0200, Borislav Petkov wrote:
> On Tue, Oct 03, 2017 at 08:54:22PM -0700, Ricardo Neri wrote:
> > The new function get_addr_ref_32() is almost identical to the existing
> > function insn_get_addr_ref() (used for 64-bit addresses); except for the
> > differences mentioned above. For the sake of simplicity and readability,
> > it is better to use two separate functions.
>
> You're kidding, right?
>
> You're not adding another small function - this new one is just as big. And
> almost identical.
>
> So if you split the whole handling into helpers - for example, each
> if-clause is doing very similar things - you can carve out the repeating
> pieces into helpers and then call them each time with the respective
> parameters, you can get rid of all that needless duplication.

I will create these helper functions. This change and your suggestion in
patch 18 will impact other patches in the series (e.g., the function
get_addr_ref_16() in patch 22). Would it make sense to submit a v10 and
resume review there?

Also, do you think I am still on-time to make it to v4.15?

Thanks and BR,
Ricardo
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> --