Re: [PATCH v9 13/29] x86/insn-eval: Add utility functions to get segment selector

Borislav Petkov
2017-10-18T20:29:57Z

On Tue, Oct 17, 2017 at 01:31:52PM -0700, Ricardo Neri wrote:
> I apologize for the inconvenience, I have verified that may mail client
> works properly this time. I double-checked that it did not wrap.

But did you try applying the patch which you have sent to yourself first?

Because it doesn't work here:

[boris@pd: ~/kernel/linux> test-apply.sh /tmp/ricardo.neri-calderon.13
checking file arch/x86/include/asm/inat.h
patch: **** malformed patch at line 124:  #define INAT_MAKE_GROUP(grp) ((grp << INAT_GRP_OFFS) | INAT_MODRM)

Diffing your original patch which you've sent with git and this one
which you've sent with evolution gives:

diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
index 02aff08..1c78580 100644
--- a/arch/x86/include/asm/inat.h
+++ b/arch/x86/include/asm/inat.h
@@ -97,6 +97,16 @@
- #define INAT_MAKE_GROUP(grp) ((grp << INAT_GRP_OFFS) | INAT_MODRM)
- #define INAT_MAKE_IMM(imm) (imm << INAT_IMM_OFFS)
-
+ #define INAT_MAKE_GROUP(grp) ((grp << INAT_GRP_OFFS) | INAT_MODRM)
+ #define INAT_MAKE_IMM(imm) (imm << INAT_IMM_OFFS)
+

And already those spaces at the beginning of the line must be funky
because the rest looks identical.

They should be:

00001420 2c 31 36 20 40 40 0a 20 23 64 65 66 69 6e 65 20 |,16 @@. #define

i.e., a 0x0a for LF and 0x20 for space.

Yours are

000017b0 36 20 2b 39 37 2c 31 36 20 40 40 0a c2 a0 23 64 |6 +97,16 @@...#d|

so there's 0x0a LF, but then there's 0xc2, and then there's 0xa0.

Looking at an UTF-8 table, it says:

U+00A0 c2 a0 NO-BREAK SPACE

so your patch is utf-8, no wonder it doesn't apply.

So try sending the patch again. But send it to yourself first and try
applying it.

Alternatively, git send-email supports threading with --in-reply-to=
so that is another possibility. But here you'll have to add the whole
CC-list.

Also, Documentation/process/email-clients.rst has some notes on how to
send patches with Evolution.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--