From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdJ0TfS (ORCPT ); Fri, 27 Oct 2017 15:35:18 -0400 Received: from mail-ve1eur01on0043.outbound.protection.outlook.com ([104.47.1.43]:10176 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750998AbdJ0TfM (ORCPT ); Fri, 27 Oct 2017 15:35:12 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Date: Fri, 27 Oct 2017 22:35:06 +0300 From: Leon Romanovsky To: Thomas Bogendoerfer Cc: Matan Barak , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module Message-ID: <20171027193506.GH16127@mtr-leonro.local> References: <20171027123011.10454-1-tbogendoerfer@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3cI6DWK3Xt33P8nt" Content-Disposition: inline In-Reply-To: <20171027123011.10454-1-tbogendoerfer@suse.de> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [213.57.247.46] X-ClientProxiedBy: HE1PR05CA0259.eurprd05.prod.outlook.com (2603:10a6:3:fc::11) To VI1PR0501MB1935.eurprd05.prod.outlook.com (2a01:111:e400:7b79::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d0b93e4-e81d-4cdf-c774-08d51d71d5c6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199);SRVR:VI1PR0501MB1935; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;3:sBbqwME5uVB0QCh4o6A6dBm5snJYVfGVRMUOgyGR/dD7M8Bds4avoPMCItRyHZR7P0WK9mPqg6Afc0m2E+kG0qhBVDjNQk4dD1qIpGxKVSlBmN5kNvT/70Xz/JDHAboJpNeLBfiBgXyDKFrHgf6wft1XjbC9jQE+FtAkoZlD1hA0PBbNWVfnZew10nIhklIKMOpnTWpGNnDRRE2BllX/ePWcNJTAqzRk7PA/0l76bixK4nfisZ20DiUJx+UTfl0A;25:3ELlyOdLqxTWPhMfDHotIWwWy2j0/fADlDHMk2zlH9TdTuYL4G+8F77t4UXTAaWtDN3gqkZj41uXKZnYYI57pSzgaKQ3RI59S43psJNeciBWoNgzW8TGkBgJPceBOIyHLiawP4HCvnlDGKgzAZ5me42hWfaUQrAB7+UWm6G5yDpJwbAccbQJA/pM01wvWLDL48VTfmJnDdTZdcSCXZPgQytV5pXn1JN/012lyPw85BhnuVGdb0uIsyP58P/oEfuhAxPQgiUnVk0V/6KpPsZA187WQw19FXGnTvFduUfapphsu9j694/EDPM49/kfZtgm0d1WVCO1SV3i9sZaCTVfRw==;31:cuyqbTVrCB4rMG5C89v4nzeW3y/SUvEZfTEk11g5K3i+ipEvvqRNbLllrjZK+gc5dV6jO1cfNFZpXviIOWRv3/Bb9Rvq8ehRMCx5ANHdgsVKfzWWTsWTf1ncp9Gz7GL4sgxyf3d4hhOvEU/I48kbnbgbnEWLmVNkAHNwPKgSqBmU+pKrtQUFoAkRcyPT8No7LnLPL5YFnY6SgPHfGiQcd/LaGvpEyieMrPiXF/uol/I= X-MS-TrafficTypeDiagnostic: VI1PR0501MB1935: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;20:Bw2OAQSGH4jyz8WLLkcLzcX6Be3wbMvwLl/jZ+1HfxY4QlwL9PHYCr/VqaCk708r7VSqD+JnFcWXJP6E/f9wF6BL5a6FuikDBDdPJeiWztMaQgWRz2WuT7BM/SKbRYY8ApcArxHqsO6fnJ5RtV/V/dqBBxBg9oDrsihRD+/eleyRIRidY6R2zS8z23PSY+P4slO7ExCKZKX9UpU32PaOG+k+CnAxFng8UbcyrEqKacezYE2IJyvY7aAmoVMwjPoBoNtHY+mRremyenpXHcJwASq/tK9x7GHPIKyKeZeq12MgTiz7U6y2B0fuKsf9+aUfIyO0eNMiuh6taOJ9jSrpr8pELzS5lXmq2jClxutdWX7naAEnITZz2z1wwZMDN2ZZL775yiPWbFbUx8KvK461GtovAJMzns/RxXPGebxfMbq2GL2z3BxPLVzUpsjDgFaP2Y2pJQJmrt1MbbC2lwfU69WkNMMGThMhqpVxaV/sHo1xQLmFnfYGKxohN6KWTjlm;4:iIlZkrT6DsjetDMC3y6FHxIankjHAqRWdh3ZSDoTSvNF5qIW7J1Wwsm4cd4KeBf3SeNccmB9eL+RC4O5jBo4RNFsk0nXp+MFnOwFsKmAs2S18svUeY1ikboCXmQkLsg9GVhQcDgl4rhsp4JhL91zkEp2HBxV1ju1r41QwM3CPgZJT6UiG6qYsmsOJCc/dZWXHEaaYhOgMcXFCeIaSOySI8Hf7UkQo5mRizKEZ33BqZfcKUGdcr4yB74Sw8lsElH24pfQvbkNTlfiLQcx6HIytd5l8AUl6VglfX3aUkx7yr0= X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0501MB1935;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0501MB1935; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(376002)(346002)(39860400002)(199003)(24454002)(189002)(6486002)(84326002)(2906002)(1076002)(21480400003)(63394003)(83506002)(5660300001)(98436002)(106356001)(6116002)(229853002)(575784001)(86362001)(2950100002)(97736004)(3846002)(76176999)(68736007)(4326008)(16586007)(25786009)(33656002)(6246003)(76506005)(6666003)(54356999)(6496005)(105586002)(189998001)(50986999)(6306002)(7736002)(101416001)(53936002)(305945005)(8936002)(81156014)(54906003)(66066001)(966005)(16526018)(81166006)(58126008)(8676002)(9686003)(316002)(478600001)(6916009)(18370500001)(2700100001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB1935;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0501MB1935;23:90jDfA1Hqvqp2fNWL1WiRdH6G9FlF5tGRlrJZqI?= =?us-ascii?Q?6DzIpiFhXc77C/661a9U3t2beuMcl72WY/SERGsalWBL2oUzMBTx/zeIflYS?= =?us-ascii?Q?XhNEW48g8lleettVRrcWKSZPdBrC6oZP4K0ZwtXrgLg9LPGu/I6rm86zZtDf?= =?us-ascii?Q?g0nWavrXCsT/OXVxifpovpyhhzFkr929n2biFBI4wlR9H9/9C0/ZdHARPV99?= =?us-ascii?Q?4yrjoAbUpUfRyt7ENipIK+rBRtlBXQiGB8Hbs5OanHGrBM+z7Op3edeD0BqT?= =?us-ascii?Q?Mm9RKZgYPGKW7ZKZkZA4IKsWEkxWs8wHiLGKleyGzKzhnAVdZ46IchuRGHTk?= =?us-ascii?Q?OCTw6hfdRbeWnmqeZbh/TW3b8M49gYUJOBq4FkV81YCQqM4eV90dyuTgipJw?= =?us-ascii?Q?z/5hj3wwb92xkREO9OAByAuu1HbcocE1bPHH9QWBnJ5Tzbd+dfUuDAS9hop+?= =?us-ascii?Q?fK4LUc/Z4dDgVkWGQVGEMDVAiJBM6V1YNywW1n8Z8YC9mEiqqew0EgSNUsV8?= =?us-ascii?Q?IiiyVYnoSs67oCMASI0WTjctTXsIWXCpAB08DtQ+0mQcHE7FYJ9af6cZa7dE?= =?us-ascii?Q?jv5Hst5mbJrXoVHNgRKMupb+nO9e2aab47FS5kV8wp1kOhyw4BldQRKR5kiG?= =?us-ascii?Q?KMVbiHwDLsi8a3lVWyjuPPEqmrSnEiR7bH9QH0AEbowYlQ6Di9fTjyBoeEkY?= =?us-ascii?Q?i9VhTARpWJmRQkxD11LWOmEsQnawqMkfOWdtYUKAiufQBEDbjGh/BAYNqcS2?= =?us-ascii?Q?yleu2yKpalPp1yhDUgk/UIoE+VXFGWatomzjFFsfgKkt92pqdHBXB/kWM1JB?= =?us-ascii?Q?StElb3pixtIkUjEj74cChXK0flQ994aSb+WE+2bjMetDvnmte5+SIBziM3Zi?= =?us-ascii?Q?KjJcYbljNuGVwPN8p8wfQo9ihaboILh5PihLLPTByZkMJ0Z3OH9aBC/0kOCr?= =?us-ascii?Q?dvF5YeD8oAvyqtAZgx8jVLCnR6zjy6wuCtm5tf2bOWz3BrQsPwje4MNybJbJ?= =?us-ascii?Q?JggtvMu8ifDSDZQq2/vn8xTBjGXu03RyaxUqXYLF0mcSoOc7XK0zymg7O1y8?= =?us-ascii?Q?G/Ak2vq5PgLAcBVInm4iNx2Mc3Ybl6JISUFWAg4GQrDuaExppTHya3D2VR0g?= =?us-ascii?Q?92U2Se2lHG9pj/VbP01IZq/bWTfYdzQR/RThU5ZEjLSrIdOn2T3OVBdf1u/r?= =?us-ascii?Q?V9hPUFNJ+ngQhI+uMdhPDmaLPYPFP5OnTLXBBXnHmEzvml1h/Xvnssc9RqB+?= =?us-ascii?Q?ilEH1e9k0JGsUKAM9O7RK+0M2pdomHQ3AWJJcV0PMCgJevj1skeCLNrMOyHE?= =?us-ascii?Q?/MBfElsfegMJst+oJwGBq6RwoOW/gM7n9r4PeMMjdoUq7ozFjfdeMWtBfWsf?= =?us-ascii?Q?+ifviGg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;6:Lj3XwyDPZxbfEa15wk7ri8w67shwKWf2ZVbsl0TXlmiW3CWw+lO4FEnmWFvspXRQeTXGCdoXCObL6bzKbOQrqjzuYTIvALmTiOTJ/ZoUCnZtUYPriO7qJ6Cx93v5tBp28JLabMjzizpuf95I3UYPHtjh8vPwGtlrXRLy+PRE8VQnDKLx1vNVSk7mS7Vo4YIh2nivijOynInwmyWtb3xw4unyfL3wyXNWt4VgI5weGYFe9PnP3YKU0ftSmev7Ovq7I+N5l0mI6VHLSXkOay/xPd3JssTIsb++VXJFLRHHlM6etTX4a4rxultfLQU+AdeKw9KgPrP86kDAb3uB/6DA+Q==;5:bHIL2TMTNB4q5NapISLmttD48m/T2c17kXCtIxipXdkXNUpgWEvLldVgqrXv/+CS0eoNE6M8Y4RtA7HmKmK0xfxtzsJG5TxajBLJQoOQJ+7JUvCxkedwM28xCJWyoCtzs8zmgfTsA5HlGEvla6KvRg==;24:ZzCBIuaWD6r4BO5UXYToUJkGn2RYBGo/Q759Z6ya4ThIwno04ASKH81OQQA06w05L+9HKdrUG3D83jlyffVkb5SCeextS3+7JHSNbLImVU8=;7:omDJfomN2YCiMFgjDabdPHJYsc6BiVrX/XL1xIaH9JPqR/P6Qj1oDWFmjinSwjuu0z/qAznXQ3kwiowWePVvsUiHe1tvH2ybYh9z+bOhS+wUKGumP/6mNbv0qb6MgjeIjmqQ38WvbvGnz6E86xDHUkeMmuxgRiwOBxx3zOOn7XJ+nCcJAIQ+9d+kLHu/MQgzMemZRZoTugZn10xYNVk2US1ENFlKLT/BsLq3oSu7u2c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 19:35:09.4439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d0b93e4-e81d-4cdf-c774-08d51d71d5c6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1935 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3cI6DWK3Xt33P8nt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote: > If there is no SFP module plugged into a port of mlx5 cards > 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument. > This causes tools like 'ibstat' to malfunction. This change adjusts mlx5 > to all other RoCE/iWarp drivers, which always return valid speed/width. Like Parav, I have mixed feelings about such change. It returns EINVAL if nothing is connected and it is right thing to do. It is hard to call "valid speed/width" for unconnected port. I would like to have ibstat and other drivers fixed instead of converting mlx5 to be wrong. Proposed change breaks existing scripts. Thanks > > Signed-off-by: Thomas Bogendoerfer > --- > drivers/infiniband/hw/mlx5/main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index 260f8be1d0ed..4388618e3434 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -246,7 +246,10 @@ static int translate_eth_proto_oper(u32 eth_proto_oper, u8 *active_speed, > *active_speed = IB_SPEED_EDR; > break; > default: > - return -EINVAL; > + /* Unknown */ > + *active_width = IB_WIDTH_1X; > + *active_speed = IB_SPEED_SDR; > + break; > } > > return 0; > -- > 2.12.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --3cI6DWK3Xt33P8nt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnzimoACgkQ5GN7iDZy WKe1Ew/7BPkSZoCYS5+4ABB5Fweh7ZQRor1TY2LP4ZGk/wSFFlaOhgxTjzFzxS+9 TNfVaQBiC90VAVbdRCGgZJEePfqeFt63g0b/NaYX/kJ5pvHcB/bIgs7kRKTG+qZ9 vQT4DD6946x3Yp/mkZsXdU3H/mJRAs1y6jFp4hqrRZcWX5GJsYYhel8ElVqVK5MY oLq2hoYuBMSStKexSIblB0KbBSjBHRMkCvqgmN1QjM0974T1ZP6VHLiZ9bQGNoAI Ba/163HDh3KuaX9H8NLVp8rwvvXCpxENoclZrdCt1mhnJ0WZT9+r0/2wnlSx2sTn emBny2TFOnv+4lyDwgm8fgJ55GqWOK73EJgiUVJmoQmzylVJhF0e1aIyJ0DZNzIF vG5EfCRNKRUkkit4DTQ2coybGwez2uKxf5wW7jG9qjinbiIg6e87tcsKQiLC4eCB LNPRumi9DyWiQXhtLv6JSw3MQjwEs8gSWe3nZg+CzzupZcSu/E0799F5I5qa83+N ib8d7VgrSee04DcB//oM/iiyNWrAwMOB1tA6wBSZreObjCkn3tzSd6odse5e2Xq3 Ty/feEFvggozzxARig9Q3/eKUmtgfsRFl/rCVJwSCKLHqf3lP0kjrT1yCdleV5wV FHXgrjR7+NBd4DK7j897BmezI0lqbFIsfMbxqP4ZTQsdInH3ex4= =dApQ -----END PGP SIGNATURE----- --3cI6DWK3Xt33P8nt--