Re: [PATCH 03/18] x86/asm/64: Move SWAPGS into the common iret-to-usermode path

Andy Lutomirski
2017-10-27T15:44:42Z

On Thu, Oct 26, 2017 at 7:28 AM, Borislav Petkov <bp@suse.de> wrote:
> On Thu, Oct 26, 2017 at 07:13:32AM -0700, Dave Hansen wrote:
>> I kinda appreciate the verbosity. When I see a jump to such a label, I
>
> Sorry but this and other labels' names are just ridiculously long.
> swapgs_restore_regs_return or swapgs_restore or somesuch are perfectly
> fine.
>

Hmm. I'm kind of tempted to rename it to exit_to_usermode. After
all, it's the thing you call after prepare_exit_to_usermode, and its
preconditions rather nontrivial and are quite likely to become even
less trivial in the future.