From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbdJ3Hdd (ORCPT ); Mon, 30 Oct 2017 03:33:33 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:49626 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbdJ3Hdc (ORCPT ); Mon, 30 Oct 2017 03:33:32 -0400 X-Google-Smtp-Source: ABhQp+Q7k8Kvzws3/EZ1GZTU0ix8tALQQOAP0TsrwZK0Xdlds91q2qzSxLC/pQKyu02MDn4YPN+l5w== Date: Mon, 30 Oct 2017 08:33:22 +0100 From: Christoffer Dall To: Dongjiu Geng Cc: marc.zyngier@arm.com, christoffer.dall@linaro.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, huangshaoyu@huawei.com, wuquanming@huawei.com Subject: Re: [PATCH v4] KVM: arm/arm64: fix the incompatible matching for external abort Message-ID: <20171030073322.GR2166@lvm> References: <1509343518-27137-1-git-send-email-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509343518-27137-1-git-send-email-gengdongjiu@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 02:05:18PM +0800, Dongjiu Geng wrote: > kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but > calls kvm_vcpu_trap_get_fault_type() that only returns the fault class, > thus reducing the scope of the check. This doesn't cause any observable > bug yet as we end-up matching a closely related syndrome for which we > return the same value. > > Using kvm_vcpu_trap_get_fault() instead fixes it for good. > > Signed-off-by: Dongjiu Geng > Acked-by: Marc Zyngier Applied, thanks. -Christoffer > --- > arch/arm/include/asm/kvm_emulate.h | 2 +- > arch/arm64/include/asm/kvm_emulate.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h > index 98089ff..7571b4e 100644 > --- a/arch/arm/include/asm/kvm_emulate.h > +++ b/arch/arm/include/asm/kvm_emulate.h > @@ -203,7 +203,7 @@ static inline u8 kvm_vcpu_trap_get_fault_type(struct kvm_vcpu *vcpu) > > static inline bool kvm_vcpu_dabt_isextabt(struct kvm_vcpu *vcpu) > { > - switch (kvm_vcpu_trap_get_fault_type(vcpu)) { > + switch (kvm_vcpu_trap_get_fault(vcpu)) { > case FSC_SEA: > case FSC_SEA_TTW0: > case FSC_SEA_TTW1: > diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h > index e5df3fc..8c918c5 100644 > --- a/arch/arm64/include/asm/kvm_emulate.h > +++ b/arch/arm64/include/asm/kvm_emulate.h > @@ -237,7 +237,7 @@ static inline u8 kvm_vcpu_trap_get_fault_type(const struct kvm_vcpu *vcpu) > > static inline bool kvm_vcpu_dabt_isextabt(const struct kvm_vcpu *vcpu) > { > - switch (kvm_vcpu_trap_get_fault_type(vcpu)) { > + switch (kvm_vcpu_trap_get_fault(vcpu)) { > case FSC_SEA: > case FSC_SEA_TTW0: > case FSC_SEA_TTW1: > -- > 1.9.1 >