From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752757AbdJ3LsN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 07:48:13 -0400
Received: from mail-lf0-f44.google.com ([209.85.215.44]:55153 "EHLO
        mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751811AbdJ3LsM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 07:48:12 -0400
X-Google-Smtp-Source: ABhQp+R366aRbD05c4e9HDbm5oziRciA+pJE77Rgr3QWBcCv0c5oR9JWM6ze5KLm6u2B9HlexQVG+g==
Date: Mon, 30 Oct 2017 12:48:09 +0100
From: Johan Hovold <johan@kernel.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Kees Cook <keescook@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Alex Elder <elder@kernel.org>,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()
Message-ID: <20171030114809.GF7223@localhost>
References: <20171024144938.GA41224@beast>
 <55a6647a-8565-09e8-9f45-d9048c7dd916@linaro.org>
 <20171030113202.GB7223@localhost>
 <558a6d02-515e-9998-18cc-b9b77d2b1d63@nexus-software.ie>
 <20171030113819.GD7223@localhost>
 <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 30, 2017 at 11:44:22AM +0000, Bryan O'Donoghue wrote:
> 
> 
> On 30/10/17 11:38, Johan Hovold wrote:
> > On Mon, Oct 30, 2017 at 11:35:50AM +0000, Bryan O'Donoghue wrote:
> >> On 30/10/17 11:32, Johan Hovold wrote:
> >>> The right thing to do here is to respin your patch from last year which
> >>> converts the loopback driver to use the timeout handling in greybus
> >>> core.
> >>
> >> Actually I wasn't clear if you wanted to to that yourself aswell as the
> >> rest if it.
> >>
> >> But sure I can do that conversion, it's on my list.
> > 
> > IIRC it was basically done. Just some odd locking that could now also be
> > removed.
> > 
> > Thanks,
> > Johan
> > 
> 
> I think once Kees' change is applied to operation.c and we convert the 
> async stuff to operation.c's callbacks there ought to be no use of 
> timers, linked lists of operations.

That's correct.

> I'll probably need at least a day to look at that, so it'll be the 
> weekend before I can really allocate time.

Cool. I'm quite sure I just rebased your loopback conversion patch on my
core timeout handling and used that to test the core implementation, so
it should be straight forward.

Thanks,
Johan