From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752060AbdJ3NSr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 09:18:47 -0400
Received: from lelnx194.ext.ti.com ([198.47.27.80]:22208 "EHLO
        lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751378AbdJ3NSp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 09:18:45 -0400
Date: Mon, 30 Oct 2017 08:18:31 -0500
From: Bin Liu <b-liu@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb_core: mark expected switch fall-through
Message-ID: <20171030131831.GB3964@uda0271908>
Mail-Followup-To: Bin Liu <b-liu@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171024031043.GA23669@embeddedor.com>
 <20171027164447.GA15590@uda0271908>
 <20171027164949.GA20585@kroah.com>
 <20171027165614.GB65@LTA0271908.dhcp.ti.com>
 <20171030085118.GA28997@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171030085118.GA28997@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 30, 2017 at 09:51:18AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote:
> > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote:
> > > > Hi,
> > > > 
> > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote:
> > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > > > where we are expecting to fall through.
> > > > > 
> > > > > Addresses-Coverity-ID: 1397608
> > > > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > > > 
> > > > Applied with the above Coverity-ID message removed.
> > > 
> > > Why?  It's good to track these things.
> > 
> > hmm, I thought we don't want non-kernel related information in the commit
> > message.
> 
> This is kernel-related information.
> 
> We don't want foolish "Id:" lines, from gerrit instances, as they are no
> help at all because we can not do anything with them.
> 
> We _do_ want identifiers that are globally unique that provide real
> information, like public bugzilla ids, and tools like coverity.  So for
> things like this, always keep them on.

Thanks for clarifying this.

> 
> I've added it back by hand now.

Thanks,
-Bin.