From: Tejun Heo <tj@kernel.org>
To: syzbot
<bot+f7b556d1766502a69d85071d2ff08bd87be53d0f@syzkaller.appspotmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in ata_qc_issue
Date: Mon, 30 Oct 2017 08:23:00 -0700 [thread overview]
Message-ID: <20171030152300.GG3252168@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <001a11425956f5f3d0055c82f08d@google.com>
Hello,
On Fri, Oct 27, 2017 at 01:19:01AM -0700, syzbot wrote:
> WARNING: CPU: 1 PID: 2909 at drivers/ata/libata-core.c:5391
> ata_qc_issue+0x519/0xea0 drivers/ata/libata-core.c:5390
...
> sg_common_write.isra.17+0xf80/0x1c10 drivers/scsi/sg.c:806
> sg_write+0x7a0/0xc90 drivers/scsi/sg.c:677
> __vfs_write+0xef/0x970 fs/read_write.c:468
> vfs_write+0x189/0x510 fs/read_write.c:518
> SYSC_write fs/read_write.c:565 [inline]
> SyS_write+0xef/0x220 fs/read_write.c:557
It's issuing an invalid command (data command w/o any data) via SG and
libata triggered a warning before failing the command. The warning is
still somewhat meaningful in that if we ever hit that during normal
kernel operation, it shows the caller who's screwing up. idk, we can
shut it up (nothing is really wrong in this case) or make it a bit
smarter (filter out invalid sg commands earlier).
Thanks.
--
tejun
prev parent reply other threads:[~2017-10-30 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 8:19 WARNING in ata_qc_issue syzbot
2017-10-27 8:20 ` Dmitry Vyukov
2017-10-30 15:23 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030152300.GG3252168@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=bot+f7b556d1766502a69d85071d2ff08bd87be53d0f@syzkaller.appspotmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox