From: Bin Liu <b-liu@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: Convert timers to use timer_setup()
Date: Mon, 30 Oct 2017 11:33:03 -0500 [thread overview]
Message-ID: <20171030163303.GC3964@uda0271908> (raw)
In-Reply-To: <20171030085215.GB28997@kroah.com>
On Mon, Oct 30, 2017 at 09:52:15AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Oct 27, 2017 at 11:24:22AM -0500, Bin Liu wrote:
> > Hi,
> >
> > On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote:
> > > In preparation for unconditionally passing the struct timer_list pointer to
> > > all timer callbacks, switch to using the new timer_setup() and from_timer()
> > > to pass the timer pointer explicitly.
> > >
> > > Instead of a per-device static timer variable, a spare timer "dev_timer"
> > > is added to the musb structure for devices to use for their per-device
> > > timer.
> > >
> > > Cc: Bin Liu <b-liu@ti.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: linux-usb@vger.kernel.org
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> > > ---
> > > drivers/usb/musb/am35x.c | 24 +++++++++++-------------
> > > drivers/usb/musb/blackfin.c | 13 ++++++-------
> > > drivers/usb/musb/blackfin.h | 2 --
> > > drivers/usb/musb/da8xx.c | 26 ++++++++++++--------------
> > > drivers/usb/musb/davinci.c | 20 +++++++++-----------
> > > drivers/usb/musb/musb_core.c | 6 +++---
> > > drivers/usb/musb/musb_core.h | 1 +
> > > drivers/usb/musb/musb_dsps.c | 7 ++++---
> > > drivers/usb/musb/tusb6010.c | 20 +++++++++-----------
> > > 9 files changed, 55 insertions(+), 64 deletions(-)
> >
> > [snip]
> >
> > > diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
> > > index 20f4614178d9..e8573975743d 100644
> > > --- a/drivers/usb/musb/musb_core.h
> > > +++ b/drivers/usb/musb/musb_core.h
> > > @@ -345,6 +345,7 @@ struct musb {
> > > struct list_head pending_list; /* pending work list */
> > >
> > > struct timer_list otg_timer;
> > > + struct timer_list dev_timer;
> >
> > Now since dev_timer is added in struct musb for glue drivers,
> >
> > > struct notifier_block nb;
> > >
> > > struct dma_controller *dma_controller;
> > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> > > index f6b526606ad1..e3d0e626a5d6 100644
> > > --- a/drivers/usb/musb/musb_dsps.c
> > > +++ b/drivers/usb/musb/musb_dsps.c
> > > @@ -282,9 +282,10 @@ static int dsps_check_status(struct musb *musb, void *unused)
> > > return 0;
> > > }
> > >
> > > -static void otg_timer(unsigned long _musb)
> > > +static void otg_timer(struct timer_list *t)
> > > {
> > > - struct musb *musb = (void *)_musb;
> > > + struct dsps_glue *glue = from_timer(glue, t, timer);
> > > + struct musb *musb = platform_get_drvdata(glue->musb);
> > > struct device *dev = musb->controller;
> > > unsigned long flags;
> > > int err;
> > > @@ -480,7 +481,7 @@ static int dsps_musb_init(struct musb *musb)
> > > }
> > > }
> > >
> > > - setup_timer(&glue->timer, otg_timer, (unsigned long) musb);
> > > + timer_setup(&glue->timer, otg_timer, 0);
> >
> > this glue->timer is duplicate. It can be removed and use musb->dev_timer
> > instead as other glue drivers do.
>
> I do not understand your review comments at all. Can you do the fixup
> here to use timer_setup for the musb timer code?
The fixup patch was sent. Here is my Acked-by for this patch.
Acked-by: Bin Liu <b-liu@ti.com>
Regards,
-Bin.
prev parent reply other threads:[~2017-10-30 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 10:08 [PATCH] usb: musb: Convert timers to use timer_setup() Kees Cook
2017-10-27 16:24 ` Bin Liu
2017-10-30 8:52 ` Greg Kroah-Hartman
2017-10-30 13:17 ` Bin Liu
[not found] ` <1509380996-1271-1-git-send-email-b-liu@ti.com>
2017-10-30 21:29 ` [PATCH] usb: musb: dsps: remove the duplicated timer Kees Cook
2017-10-30 21:44 ` Greg Kroah-Hartman
2017-10-30 16:33 ` Bin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030163303.GC3964@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).