From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932969AbdJ3VoG (ORCPT ); Mon, 30 Oct 2017 17:44:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53716 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbdJ3VoF (ORCPT ); Mon, 30 Oct 2017 17:44:05 -0400 Date: Mon, 30 Oct 2017 22:44:15 +0100 From: Greg Kroah-Hartman To: Kees Cook Cc: Bin Liu , linux-usb@vger.kernel.org, LKML Subject: Re: [PATCH] usb: musb: dsps: remove the duplicated timer Message-ID: <20171030214415.GB10043@kroah.com> References: <20171030131735.GA3964@uda0271908> <1509380996-1271-1-git-send-email-b-liu@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > > Now struct musb has the timer (dev_timer) for glue drivers, so let's > > remove the duplicated timer defined in dsps glue driver, and use > > dev_timer defined in struct musb. > > > > Signed-off-by: Bin Liu > > Reviewed-by: Kees Cook > > Thanks for this; it wasn't clear to me if both timers needed to exist > (i.e. glue operated independently from the musb object), so I didn't > make this change myself. > > Greg, it probably makes sense to just take both patches. Does that work for you? Yes, I can do that, thanks. greg k-h