From: motobud@gmail.com
To: boris.brezillon@free-electrons.com
Cc: Brent Taylor <motobud@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] mtd: nand: Fix writing mtdoops to nand flash.
Date: Mon, 30 Oct 2017 22:32:45 -0500 [thread overview]
Message-ID: <20171031033246.8576-1-motobud@gmail.com> (raw)
In-Reply-To: <20171030042343.24551-1-motobud@gmail.com>
From: Brent Taylor <motobud@gmail.com>
When mtdoops calls mtd_panic_write, it eventually calls
panic_nand_write in nand_base.c. In order to properly
wait for the nand chip to be ready in panic_nand_wait,
the chip must first be selected.
When using the atmel nand flash controller, a panic
would occur due to a NULL pointer exception.
Signed-off-by: Brent Taylor <motobud@gmail.com>
---
Changes in v2:
- drop deselecting the chip
- move select_chip and panic_nand_wait after panic_nand_get_device
drivers/mtd/nand/nand_base.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 12edaae17d81..2093667e2bcb 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2802,12 +2802,16 @@ static int panic_nand_write(struct mtd_info *mtd, loff_t to, size_t len,
struct mtd_oob_ops ops;
int ret;
- /* Wait for the device to get ready */
- panic_nand_wait(mtd, chip, 400);
+ int chipnr = (int)(to >> chip->chip_shift);
/* Grab the device */
panic_nand_get_device(chip, mtd, FL_WRITING);
+ chip->select_chip(mtd, chipnr);
+
+ /* Wait for the device to get ready */
+ panic_nand_wait(mtd, chip, 400);
+
memset(&ops, 0, sizeof(ops));
ops.len = len;
ops.datbuf = (uint8_t *)buf;
--
2.14.2
next prev parent reply other threads:[~2017-10-31 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 4:23 [PATCH] Fix writing mtdoops to nand flash motobud
2017-10-30 8:23 ` Boris Brezillon
2017-10-30 12:46 ` Brent Taylor
2017-10-30 13:15 ` Boris Brezillon
2017-10-31 3:32 ` motobud [this message]
2017-10-31 10:18 ` [PATCH v2] mtd: nand: " Boris Brezillon
2017-11-02 10:48 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031033246.8576-1-motobud@gmail.com \
--to=motobud@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox