From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arun Kumar Neelakantam <aneela@codeaurora.org>
Cc: ohad@wizery.com, sricharan@codeaurora.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] rpmsg: glink: Initialize the "intent_req_comp" completion variable
Date: Mon, 30 Oct 2017 21:27:15 -0700 [thread overview]
Message-ID: <20171031042715.GL1275@minitux> (raw)
In-Reply-To: <1509342085-15185-1-git-send-email-aneela@codeaurora.org>
On Sun 29 Oct 22:41 PDT 2017, Arun Kumar Neelakantam wrote:
> The "intent_req_comp" variable is used without initialization which
> results in NULL pointer dereference in qcom_glink_request_intent().
>
> we need to initialize the completion variable before using it.
>
> Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable")
> Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Thanks, applied.
Regards,
Bjorn
> ---
> drivers/rpmsg/qcom_glink_native.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index 5dcc9bf..fcd46ab 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -227,6 +227,7 @@ static struct glink_channel *qcom_glink_alloc_channel(struct qcom_glink *glink,
>
> init_completion(&channel->open_req);
> init_completion(&channel->open_ack);
> + init_completion(&channel->intent_req_comp);
>
> INIT_LIST_HEAD(&channel->done_intents);
> INIT_WORK(&channel->intent_work, qcom_glink_rx_done_work);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2017-10-31 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 5:41 [PATCH V1] rpmsg: glink: Initialize the "intent_req_comp" completion variable Arun Kumar Neelakantam
2017-10-31 4:27 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031042715.GL1275@minitux \
--to=bjorn.andersson@linaro.org \
--cc=aneela@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox