From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbdJaHt7 (ORCPT ); Tue, 31 Oct 2017 03:49:59 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:50443 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdJaHt5 (ORCPT ); Tue, 31 Oct 2017 03:49:57 -0400 X-Google-Smtp-Source: ABhQp+T6udnviP5iZLdScyBAq57xS1r+2JEd1pIyg65waU0paF0B//YUn0XDuJ8X+Rj419vb37f13g== Date: Tue, 31 Oct 2017 08:49:54 +0100 From: Johan Hovold To: "Gustavo A. R. Silva" Cc: Johan Hovold , David Laight , "=?iso-8859-1?Q?'Bj=F8rn?= Mork'" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs Message-ID: <20171031074954.GM7223@localhost> References: <20171027203906.GA7054@embeddedor.com> <87k1zf4k24.fsf@miraculix.mork.no> <063D6719AE5E284EB5DD2968C1650D6DD00A8B34@AcuExch.aculab.com> <20171030144220.GK7223@localhost> <20171030235002.Horde.gdw7F_ltZVrS1ZF-scG1Ps1@gator4166.hostgator.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171030235002.Horde.gdw7F_ltZVrS1ZF-scG1Ps1@gator4166.hostgator.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote: > Quoting Johan Hovold : > > This code is pretty hard to read as is and could really use some clean > > up... > > > > I agree. I'll send a V2 of this patch and then let's see if I can help > with some code refactoring. Sounds good! Thanks, Johan