From: Greg KH <gregkh@linuxfoundation.org>
To: Long Li <longli@exchange.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
Paul Meyer <Paul.Meyer@microsoft.com>
Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file
Date: Tue, 31 Oct 2017 09:42:48 +0100 [thread overview]
Message-ID: <20171031084248.GA11479@kroah.com> (raw)
In-Reply-To: <20171031000803.11571-1-longli@exchange.microsoft.com>
On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote:
> From: Paul Meyer <Paul.Meyer@microsoft.com>
>
> While reading in more than one block (50) of KVP records, the allocation goes
> per block, but the reads used the total number of allocated records (without
> resetting the pointer/stream). This causes the records buffer to overrun when
> the refresh reads more than one block over the previous capacity (e.g. reading
> more than 100 KVP records whereas the in-memory database was empty before).
Please wrap changelogs at 72 columns like your editor asked you to...
>
> Fix this by reading the correct number of KVP records from file each time.
>
> Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com>
> ---
Why is your name not also on the signed-off-by chain if you are
forwarding on a patch from someone else?
Is this patch also needed on stable kernels?
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-31 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 0:08 [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file Long Li
2017-10-31 8:42 ` Greg KH [this message]
2017-10-31 18:10 ` Long Li
2017-10-31 19:42 ` Greg KH
2017-10-31 20:01 ` Long Li
-- strict thread matches above, loose matches on Subject: below --
2017-10-31 19:00 Long Li
2017-10-31 20:04 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031084248.GA11479@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Paul.Meyer@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@exchange.microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox