From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbdJaJjn (ORCPT ); Tue, 31 Oct 2017 05:39:43 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:52450 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbdJaJjm (ORCPT ); Tue, 31 Oct 2017 05:39:42 -0400 X-Google-Smtp-Source: ABhQp+SLiIb65xIn5rCW3v4x5kOPoMzbVPlEGHN2G1SWrhY5JpHHNXesd9ISUPoA+wkNBTd/g8g/8A== Date: Tue, 31 Oct 2017 10:39:38 +0100 From: Ingo Molnar To: changbin.du@intel.com, Masahiro Yamada , Michal Marek Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, build: Improve the isolinux searching of isoimage generation Message-ID: <20171031093937.7xvsvwwrm5wtqomb@gmail.com> References: <1509425132-31514-1-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509425132-31514-1-git-send-email-changbin.du@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * changbin.du@intel.com wrote: > From: Changbin Du > > Recently I failed to build isoimage target, because the path of isolinux.bin > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32. > > This patch has a improvement of the file search: > - Don't print the raw shell commands. It doesn't make sense to show the > entire big block. > - Show a error message instead of silent fail. > - Add above new paths. > > Now it becomes: > Kernel: arch/x86/boot/bzImage is ready (#62) > rm -rf arch/x86/boot/isoimage > mkdir arch/x86/boot/isoimage > Using /usr/lib/ISOLINUX/isolinux.bin > Using /usr/lib/syslinux/modules/bios/ldlinux.c32 > cp arch/x86/boot/bzImage arch/x86/boot/isoimage/linux > ... > > Before: > Kernel: arch/x86/boot/bzImage is ready (#63) > rm -rf arch/x86/boot/isoimage > mkdir arch/x86/boot/isoimage > for i in lib lib64 share end ; do \ > if [ -f /usr/$i/syslinux/isolinux.bin ] ; then \ > cp /usr/$i/syslinux/isolinux.bin arch/x86/boot/isoimage ; \ > if [ -f /usr/$i/syslinux/ldlinux.c32 ]; then \ > cp /usr/$i/syslinux/ldlinux.c32 arch/x86/boot/isoimage ; \ > fi ; \ > break ; \ > fi ; \ > if [ $i = end ] ; then exit 1 ; fi ; \ > done > arch/x86/boot/Makefile:161: recipe for target 'isoimage' failed > make[1]: *** [isoimage] Error 1 I like these changes. Could we please further improve it: for example the boot image build messages are still pretty unstructured, while regular build system messages come in the following format: CC arch/x86/events/msr.o RELOCS arch/x86/realmode/rm/realmode.relocs OBJCOPY arch/x86/realmode/rm/realmode.bin CC arch/x86/kernel/signal.o AS arch/x86/realmode/rmpiggy.o CC ipc/msg.o AR arch/x86/ia32/built-in.o CC arch/x86/events/amd/iommu.o CC init/do_mounts.o AR arch/x86/realmode/built-in.o So instead of: > Kernel: arch/x86/boot/bzImage is ready (#62) > rm -rf arch/x86/boot/isoimage > mkdir arch/x86/boot/isoimage > Using /usr/lib/ISOLINUX/isolinux.bin > Using /usr/lib/syslinux/modules/bios/ldlinux.c32 > cp arch/x86/boot/bzImage arch/x86/boot/isoimage/linux Could we make it something more streamlined and similar to the rest of the build as well, like: GEN arch/x86/boot/bzImage GEN arch/x86/boot/isoimage GEN arch/x86/boot/isoimage/linux I.e. only mention the new files built, with an appropriate prefix. I've Cc:-ed the kbuild maintainers, maybe they have a better suggestion instead of the 'GEN' abbreviation? Thanks, Ingo