From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753417AbdJaNWu (ORCPT ); Tue, 31 Oct 2017 09:22:50 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:45697 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdJaNWr (ORCPT ); Tue, 31 Oct 2017 09:22:47 -0400 X-Google-Smtp-Source: ABhQp+SmT+Inumgkn4ubtEQI4Lwni06m4GHpk4tnB9vzazR5w8aMVJVkVvoWPt8UAH/XgApeaC++mA== Date: Tue, 31 Oct 2017 14:22:44 +0100 From: Johan Hovold To: Colin King Cc: "David S . Miller" , Johan Hovold , linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hso: remove redundant unused variable dev Message-ID: <20171031132244.GP7223@localhost> References: <20171031120147.22348-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031120147.22348-1-colin.king@canonical.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 12:01:47PM +0000, Colin King wrote: > From: Colin Ian King > > The pointer dev is being assigned but is never used, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is > never read You could also have mentioned that it was a leftover since commit 4134069f3ea6 ("hso: Use static attribute groups for sysfs entry"). > Signed-off-by: Colin Ian King Reviewed-by: Johan Hovold Thanks, Johan