From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbdJaPYN (ORCPT ); Tue, 31 Oct 2017 11:24:13 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:40418 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdJaPYL (ORCPT ); Tue, 31 Oct 2017 11:24:11 -0400 Date: Tue, 31 Oct 2017 08:24:06 -0700 From: Darren Hart To: Mario.Limonciello@dell.com Cc: pali.rohar@gmail.com, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Message-ID: <20171031152406.GA55546@localhost.localdomain> References: <363404cf80b9060fca645b5e64bda8de75f59b56.1508515469.git.mario.limonciello@dell.com> <20171030115608.r2y7w33an47fkple@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 01:36:16PM +0000, Mario.Limonciello@dell.com wrote: > > > > Hint: you can move this check out of j-loop as condition is independent > > of it. > > That's true, thanks. > > > > > Also how many tokens are there? Is not quadratic solution too slow? > > > > ~< 250 on most machines is what I've seen. To me that that's a small > enough number that this is quick. It only happens at initialization. Agreed, not a hot path. Prefer simplicity to performance here. -- Darren Hart VMware Open Source Technology Center