From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbdJaVog (ORCPT ); Tue, 31 Oct 2017 17:44:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:56290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbdJaVof (ORCPT ); Tue, 31 Oct 2017 17:44:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0374E21903 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 31 Oct 2017 17:44:32 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, Tom Zanussi , Rajvi Jingar Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail Message-ID: <20171031174432.770bd509@gandalf.local.home> In-Reply-To: <150946150188.23534.2733334352688090372.stgit@devbox> References: <150946150188.23534.2733334352688090372.stgit@devbox> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Oct 2017 23:51:42 +0900 Masami Hiramatsu wrote: > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > index 74507db8bbc8..b8701fa0b8f2 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc > @@ -8,7 +8,7 @@ echo > kprobe_events > echo p:myevent _do_fork > kprobe_events > test -d events/kprobes/myevent > echo 1 > events/kprobes/myevent/enable > -echo > kprobe_events && exit 1 # this must fail > +echo > kprobe_events && exit_fail Should we keep the comment about "this must fail", otherwise it may look like a mistake. Echoing in kprobe_events returns failure here? -- Steve > echo 0 > events/kprobes/myevent/enable > echo > kprobe_events # this must succeed > clear_trace