From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
yehezkel.bernat@intel.com, linux-kernel@vger.kernel.org
Subject: Re: Excessive logging in thunderbolt driver
Date: Wed, 1 Nov 2017 09:41:54 +0200 [thread overview]
Message-ID: <20171101074154.GT2283@lahna.fi.intel.com> (raw)
In-Reply-To: <20171031224546.46ac6eab@shemminger-XPS-13-9360>
On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote:
> The thunderbolt driver needs to stop logging.
> All these debug messages and the laptop is on battery with no devices connected.
> (I did use a USB key, but that is not a thunderbolt device).
>
> IMHO a production driver should log nothing in normal operation.
> If you insist, the one message when device is found on discovery/probe
> is allowed at INFO level.
>
> All the rest should just go away, or be turned into pr_debug().
I agree and it is on my todo list for this driver.
next prev parent reply other threads:[~2017-11-01 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:45 Excessive logging in thunderbolt driver Stephen Hemminger
2017-11-01 7:41 ` Mika Westerberg [this message]
2017-11-06 19:27 ` Andreas Noever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101074154.GT2283@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=stephen@networkplumber.org \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox