From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbdKAHmS (ORCPT ); Wed, 1 Nov 2017 03:42:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:44995 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdKAHmR (ORCPT ); Wed, 1 Nov 2017 03:42:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,327,1505804400"; d="scan'208";a="1031981782" Date: Wed, 1 Nov 2017 09:41:54 +0200 From: Mika Westerberg To: Stephen Hemminger Cc: andreas.noever@gmail.com, michael.jamet@intel.com, yehezkel.bernat@intel.com, linux-kernel@vger.kernel.org Subject: Re: Excessive logging in thunderbolt driver Message-ID: <20171101074154.GT2283@lahna.fi.intel.com> References: <20171031224546.46ac6eab@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031224546.46ac6eab@shemminger-XPS-13-9360> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote: > The thunderbolt driver needs to stop logging. > All these debug messages and the laptop is on battery with no devices connected. > (I did use a USB key, but that is not a thunderbolt device). > > IMHO a production driver should log nothing in normal operation. > If you insist, the one message when device is found on discovery/probe > is allowed at INFO level. > > All the rest should just go away, or be turned into pr_debug(). I agree and it is on my todo list for this driver.