From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703AbdKAOgA (ORCPT ); Wed, 1 Nov 2017 10:36:00 -0400 Received: from mga03.intel.com ([134.134.136.65]:29786 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbdKAOf7 (ORCPT ); Wed, 1 Nov 2017 10:35:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,329,1505804400"; d="asc'?scan'208";a="169975732" Date: Wed, 1 Nov 2017 22:28:49 +0800 From: "Du, Changbin" To: Masahiro Yamada Cc: Ingo Molnar , changbin.du@intel.com, Michal Marek , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , X86 ML , Linux Kernel Mailing List Subject: Re: [PATCH] x86, build: Improve the isolinux searching of isoimage generation Message-ID: <20171101142849.GA23254@intel.com> References: <1509425132-31514-1-git-send-email-changbin.du@intel.com> <20171031093937.7xvsvwwrm5wtqomb@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ingo and Yamada, Thanks for your suggestions. I'll have a try though I am not familiar with = kbuild system. On Wed, Nov 01, 2017 at 12:17:50PM +0900, Masahiro Yamada wrote: > 2017-10-31 18:39 GMT+09:00 Ingo Molnar : > > > > * changbin.du@intel.com wrote: > > > >> From: Changbin Du > >> > >> Recently I failed to build isoimage target, because the path of isolin= ux.bin > >> changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which > >> changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32. > >> > >> This patch has a improvement of the file search: > >> - Don't print the raw shell commands. It doesn't make sense to show = the > >> entire big block. > >> - Show a error message instead of silent fail. > >> - Add above new paths. > >> > >> Now it becomes: > >> Kernel: arch/x86/boot/bzImage is ready (#62) > >> rm -rf arch/x86/boot/isoimage > >> mkdir arch/x86/boot/isoimage > >> Using /usr/lib/ISOLINUX/isolinux.bin > >> Using /usr/lib/syslinux/modules/bios/ldlinux.c32 > >> cp arch/x86/boot/bzImage arch/x86/boot/isoimage/linux > >> ... > >> > >> Before: > >> Kernel: arch/x86/boot/bzImage is ready (#63) > >> rm -rf arch/x86/boot/isoimage > >> mkdir arch/x86/boot/isoimage > >> for i in lib lib64 share end ; do \ > >> if [ -f /usr/$i/syslinux/isolinux.bin ] ; then \ > >> cp /usr/$i/syslinux/isolinux.bin arch/x86/boot/isoimage = ; \ > >> if [ -f /usr/$i/syslinux/ldlinux.c32 ]; then \ > >> cp /usr/$i/syslinux/ldlinux.c32 arch/x86/boot/is= oimage ; \ > >> fi ; \ > >> break ; \ > >> fi ; \ > >> if [ $i =3D end ] ; then exit 1 ; fi ; \ > >> done > >> arch/x86/boot/Makefile:161: recipe for target 'isoimage' failed > >> make[1]: *** [isoimage] Error 1 > > > > I like these changes. Could we please further improve it: for example t= he boot > > image build messages are still pretty unstructured, while regular build= system > > messages come in the following format: > > > > CC arch/x86/events/msr.o > > RELOCS arch/x86/realmode/rm/realmode.relocs > > OBJCOPY arch/x86/realmode/rm/realmode.bin > > CC arch/x86/kernel/signal.o > > AS arch/x86/realmode/rmpiggy.o > > CC ipc/msg.o > > AR arch/x86/ia32/built-in.o > > CC arch/x86/events/amd/iommu.o > > CC init/do_mounts.o > > AR arch/x86/realmode/built-in.o > > > > So instead of: > > > >> Kernel: arch/x86/boot/bzImage is ready (#62) > >> rm -rf arch/x86/boot/isoimage > >> mkdir arch/x86/boot/isoimage > >> Using /usr/lib/ISOLINUX/isolinux.bin > >> Using /usr/lib/syslinux/modules/bios/ldlinux.c32 > >> cp arch/x86/boot/bzImage arch/x86/boot/isoimage/linux > > > > Could we make it something more streamlined and similar to the rest of = the build > > as well, like: > > > > GEN arch/x86/boot/bzImage > > GEN arch/x86/boot/isoimage > > GEN arch/x86/boot/isoimage/linux > > > > I.e. only mention the new files built, with an appropriate prefix. > > > > I've Cc:-ed the kbuild maintainers, maybe they have a better suggestion= instead of > > the 'GEN' abbreviation? > > >=20 > Generally, the abbreviation is the tool that has processed the target, > but if you do not find an appropriate one, 'GEN' is fine. >=20 >=20 >=20 >=20 > --=20 > Best Regards > Masahiro Yamada --=20 Thanks, Changbin Du --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZ+dohAAoJEAanuZwLnPNUYrwIAIKnHBPaSAuvQ9yYP77kNhlb DVhhxksWw3+Z0WOVMk+vGt062+yWrZHoTH0XnibBip/2bYBzRbkfdW+nDxdSW6qn hj870ofVjtx3aSoUQGrzHoOIKwEgLw0XvIc/xTjgqI80bjPlMrTxkiiXO+vHjfCn JqZe0g8JTV3UDonEwwbxoklMjWuceayGRbX7pF2mo2kMs7U9weMHS4e4WASnluto /AOIlV/vOfq9/SVfLXlG698aQQm4l9ivRCWB2nGOXKe5EWNTCF7/P3nVGjBzDOaq AWf9lsBcAxb63IoswelryB7xIiVsAttyS0BMZ0+bDpx06OcN/stbYP+fRgjyH2Y= =dRXZ -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--