From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933191AbdKAQD2 (ORCPT ); Wed, 1 Nov 2017 12:03:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48798 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933135AbdKAQDY (ORCPT ); Wed, 1 Nov 2017 12:03:24 -0400 Date: Wed, 1 Nov 2017 17:03:36 +0100 From: Greg Kroah-Hartman To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Mathias Nyman Subject: Re: [PATCH] xhci: Cancel cmd_timer before cleanup the command queue in xhci_hc_died() Message-ID: <20171101160336.GA22440@kroah.com> References: <20170929091247.28604-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929091247.28604-1-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 05:12:47PM +0800, Jeffy Chen wrote: > When the cmd_timer fired, it would try to access the command struct. > So cancel it before cleanup the command queue in xhci_hc_died(), to > avoid use-after-free reported by KASAN: > [ 176.952537] BUG: KASAN: use-after-free in xhci_handle_command_timeout+0x68/0x224 > [ 176.960846] Write of size 4 at addr ffffffc0cbb01608 by task kworker/3:3/1680 > ... > [ 177.180644] Freed by task 0: > [ 177.183882] kasan_slab_free+0x90/0x15c > [ 177.188194] kfree+0x114/0x28c > [ 177.191630] xhci_cleanup_command_queue+0xc8/0xf8 > [ 177.196916] xhci_hc_died+0x84/0x358 > > Fixes: d9f11ba9f107 ("xhci: Rework how we handle unresponsive or hoptlug removed hosts") > Signed-off-by: Jeffy Chen > --- Mathias, did you miss this one? Want me to queue it up? thanks, greg k-h