From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbdKBFc1 (ORCPT ); Thu, 2 Nov 2017 01:32:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33610 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbdKBFcZ (ORCPT ); Thu, 2 Nov 2017 01:32:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EC85C601EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 1 Nov 2017 22:32:23 -0700 From: Stephen Boyd To: Masahiro Yamada Cc: linux-clk , Stephen Warren , linux-fbdev@vger.kernel.org, Michael Turquette , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , Hans de Goede , Russell King , Shawn Guo , Dong Aisheng Subject: Re: [RFC PATCH] clk: move of_clk_get_parent_count() declaration to Message-ID: <20171102053223.GH30645@codeaurora.org> References: <1507166751-2012-1-git-send-email-yamada.masahiro@socionext.com> <20171012231709.GH18706@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29, Masahiro Yamada wrote: > 2017-10-13 8:17 GMT+09:00 Stephen Boyd : > > > USB has a > > similar case, which I think Shawn Guo/Dong Aisheng was trying to > > add an OF based bulk clk_get() API called of_clk_bulk_get() > > for[1]. If this get all clks API works there too then we should > > use it. If it can be non-DT specific, even better. > > > > [1] http://lkml.kernel.org/r/1506415441-4435-1-git-send-email-aisheng.dong@nxp.com > > OK, we can implement it based on Shawn/Dong's work. > > My concern is clk-bulk.c still needs to include #, > but it is a bit odd since clk-bulk.c is a helper for clk consumers. > > Understood. I'm not concerned though, it's one place where this happens, not in a bunch of random drivers. What exactly do you need from clk-provider.h in clk-bulk.c though? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project