From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbdKBGqF (ORCPT ); Thu, 2 Nov 2017 02:46:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60202 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdKBGqC (ORCPT ); Thu, 2 Nov 2017 02:46:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE42360725 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 1 Nov 2017 23:46:01 -0700 From: Stephen Boyd To: Amit Nischal Cc: Michael Turquette , Andy Gross , David Brown , Rajendra Nayak , Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] clk: qcom: Modify RCG shared ops to support freq_tbl without XO entry Message-ID: <20171102064601.GE30645@codeaurora.org> References: <1509434380-24372-1-git-send-email-anischal@codeaurora.org> <1509434380-24372-3-git-send-email-anischal@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509434380-24372-3-git-send-email-anischal@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31, Amit Nischal wrote: > There could be some clock sources where there is no entry corresponding > XO in their frequency table, for such sources rcg2_shared_ops would > wrongly configure the RCG registers during enable/disable, which leads > to mismatch between the hardware and software rate so modify the shared > ops to handle such cases. > > Signed-off-by: Amit Nischal The shared rcg ops were orphaned and then deleted recently. Please bring this topic back up again when you have code that uses these ops. We can bring the code back in the proper way then. Also, don't hard-code 19.2MHz into the code as the CXO frequency. We've experienced that change in the past, so hard-coding those things just doesn't work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project