From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbdKBHZt (ORCPT ); Thu, 2 Nov 2017 03:25:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58192 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbdKBHZq (ORCPT ); Thu, 2 Nov 2017 03:25:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9A4EC60725 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 2 Nov 2017 00:25:44 -0700 From: Stephen Boyd To: =?iso-8859-1?Q?S=E9bastien?= Szymanski Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Fabio Estevam , Sascha Hauer , Shawn Guo , Julien Boibessot , Nicolas Colombain , Fabien Marteau Subject: Re: [PATCH 1/1] clk: imx6: refine hdmi_isfr's parent to make HDMI work on i.MX6 SoCs w/o VPU Message-ID: <20171102072544.GP30645@codeaurora.org> References: <1501584007-12433-1-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1501584007-12433-1-git-send-email-sebastien.szymanski@armadeus.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01, Sébastien Szymanski wrote: > On i.MX6 SoCs without VPU (in my case MCIMX6D4AVT10AC), the hdmi driver > fails to probe: > > [ 2.540030] dwhdmi-imx 120000.hdmi: Unsupported HDMI controller > (0000:00:00) > [ 2.548199] imx-drm display-subsystem: failed to bind 120000.hdmi > (ops dw_hdmi_imx_ops): -19 > [ 2.557403] imx-drm display-subsystem: master bind failed: -19 > > That's because hdmi_isfr's parent, video_27m, is not correctly ungated. > As explained in commit 5ccc248cc537 ("ARM: imx6q: clk: Add support for > mipi_core_cfg clock as a shared clock gate"), video_27m is gated by > CCM_CCGR3[CG8]. > > On i.MX6 SoCs with VPU, the hdmi is working thanks to the > CCM_CMEOR[mod_en_ov_vpu] bit which makes the video_27m ungated whatever > is in CCM_CCGR3[CG8]. The issue can be reproduced by setting > CCMEOR[mod_en_ov_vpu] to 0. > > Make the HDMI work in every case by setting hdmi_isfr's parent to > mipi_core_cfg. > > Signed-off-by: Sébastien Szymanski > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project