* [PATCH] staging: wlan-ng: resolve sparse endianness error.
@ 2017-10-25 6:06 Matthew Giassa
2017-11-03 11:49 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Giassa @ 2017-10-25 6:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Matthew Giassa
Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding
sparse errors as noted in the current TODO in staging-next. Original
error:
CHECK drivers/staging//wlan-ng/prism2usb.c
drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types)
drivers/staging//wlan-ng/prism2sta.c:1450:29: expected unsigned short [unsigned] [usertype] link_status_new
drivers/staging//wlan-ng/prism2sta.c:1450:29: got restricted __le16 [usertype] linkstatus
Sparse error no longer present after change.
Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
drivers/staging/wlan-ng/prism2sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index c9df450..070a237 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -1447,7 +1447,7 @@ static void prism2sta_inf_linkstatus(struct wlandevice *wlandev,
{
struct hfa384x *hw = wlandev->priv;
- hw->link_status_new = inf->info.linkstatus.linkstatus;
+ hw->link_status_new = le16_to_cpu(inf->info.linkstatus.linkstatus);
schedule_work(&hw->link_bh);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: wlan-ng: resolve sparse endianness error.
2017-10-25 6:06 [PATCH] staging: wlan-ng: resolve sparse endianness error Matthew Giassa
@ 2017-11-03 11:49 ` Greg KH
2017-11-06 15:32 ` Matthew Giassa
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-11-03 11:49 UTC (permalink / raw)
To: Matthew Giassa; +Cc: linux-kernel
On Tue, Oct 24, 2017 at 11:06:18PM -0700, Matthew Giassa wrote:
> Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding
> sparse errors as noted in the current TODO in staging-next. Original
> error:
>
> CHECK drivers/staging//wlan-ng/prism2usb.c
> drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types)
> drivers/staging//wlan-ng/prism2sta.c:1450:29: expected unsigned short [unsigned] [usertype] link_status_new
> drivers/staging//wlan-ng/prism2sta.c:1450:29: got restricted __le16 [usertype] linkstatus
>
> Sparse error no longer present after change.
>
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
> drivers/staging/wlan-ng/prism2sta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This does not apply to my tree at all :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlan-ng: resolve sparse endianness error.
2017-11-03 11:49 ` Greg KH
@ 2017-11-06 15:32 ` Matthew Giassa
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Giassa @ 2017-11-06 15:32 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
* Greg KH <gregkh@linuxfoundation.org> [2017-11-03 12:49:46 +0100]:
>On Tue, Oct 24, 2017 at 11:06:18PM -0700, Matthew Giassa wrote:
>> Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding
>> sparse errors as noted in the current TODO in staging-next. Original
>> error:
>>
>> CHECK drivers/staging//wlan-ng/prism2usb.c
>> drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types)
>> drivers/staging//wlan-ng/prism2sta.c:1450:29: expected unsigned short [unsigned] [usertype] link_status_new
>> drivers/staging//wlan-ng/prism2sta.c:1450:29: got restricted __le16 [usertype] linkstatus
>>
>> Sparse error no longer present after change.
>>
>> Signed-off-by: Matthew Giassa <matthew@giassa.net>
>> ---
>> drivers/staging/wlan-ng/prism2sta.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>This does not apply to my tree at all :(
Pardon. Duplicate of patch that had already been submitted, which Dan C.
noted. Patch can be discarded.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-06 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 6:06 [PATCH] staging: wlan-ng: resolve sparse endianness error Matthew Giassa
2017-11-03 11:49 ` Greg KH
2017-11-06 15:32 ` Matthew Giassa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox