From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756119AbdKCMzT (ORCPT ); Fri, 3 Nov 2017 08:55:19 -0400 Received: from verein.lst.de ([213.95.11.211]:60810 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbdKCMzS (ORCPT ); Fri, 3 Nov 2017 08:55:18 -0400 Date: Fri, 3 Nov 2017 13:55:16 +0100 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Cc: hch@lst.de, sagi@grimberg.me, keith.busch@intel.com, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: Re: [PATCH 3/3] nvme: fix eui_show() print format Message-ID: <20171103125516.GC25186@lst.de> References: <1509703370-20379-1-git-send-email-javier@cnexlabs.com> <1509703370-20379-4-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1509703370-20379-4-git-send-email-javier@cnexlabs.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote: > Signed-off-by: Javier González > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index ae8ab0a1ef0d..f05c81774abf 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > struct nvme_ns *ns = nvme_get_ns_from_dev(dev); > - return sprintf(buf, "%8phd\n", ns->eui); > + return sprintf(buf, "%8phD\n", ns->eui); > } > static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL); This looks correct. I wonder what the old code printed - does someone have a device with an EUI-64 at hand to quickly cross check what we did before?