From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbdKCOdv (ORCPT ); Fri, 3 Nov 2017 10:33:51 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:56456 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755751AbdKCObT (ORCPT ); Fri, 3 Nov 2017 10:31:19 -0400 X-Google-Smtp-Source: ABhQp+RTAqXUTHSMlga9dNbL/ns8+eo8PS1JxHd0QTLDB7TJag6bV3qC6APhpZz94TFQc9q/4nW9yg== From: Johan Hovold To: Rob Herring Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 6/8] serdev: ttyport: release tty lock sooner on open Date: Fri, 3 Nov 2017 15:30:57 +0100 Message-Id: <20171103143059.20749-7-johan@kernel.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171103143059.20749-1-johan@kernel.org> References: <20171103143059.20749-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Release the tty lock once tty-driver open returns to make it clear that it does not protect neither tty->termios or the serport flags. Signed-off-by: Johan Hovold --- drivers/tty/serdev/serdev-ttyport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index 334bce00364f..a8ddcd2ac5ea 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -130,6 +130,8 @@ static int ttyport_open(struct serdev_controller *ctrl) if (ret) goto err_close; + tty_unlock(serport->tty); + /* Bring the UART into a known 8 bits no parity hw fc state */ ktermios = tty->termios; ktermios.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | @@ -143,7 +145,6 @@ static int ttyport_open(struct serdev_controller *ctrl) set_bit(SERPORT_ACTIVE, &serport->flags); - tty_unlock(serport->tty); return 0; err_close: -- 2.15.0