From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081AbdKCOdu (ORCPT ); Fri, 3 Nov 2017 10:33:50 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:43347 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798AbdKCObU (ORCPT ); Fri, 3 Nov 2017 10:31:20 -0400 X-Google-Smtp-Source: ABhQp+T2M1vh+dxOLHPF9ipRpAVj1pZqCg7eL+Fit0NpTI5oENPcwMzRJ3QB0uRS/PBpilA8j/00VQ== From: Johan Hovold To: Rob Herring Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup Date: Fri, 3 Nov 2017 15:30:59 +0100 Message-Id: <20171103143059.20749-9-johan@kernel.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171103143059.20749-1-johan@kernel.org> References: <20171103143059.20749-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Serdev does not use the file abstraction and specifically there will never be anyone polling a file descriptor for POLLOUT events. Just use plain wake_up_interruptible() in the write_wakeup callback and document why it's there. Signed-off-by: Johan Hovold --- drivers/tty/serdev/serdev-ttyport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index 727664ef456c..ec07b903b7e5 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -67,7 +67,8 @@ static void ttyport_write_wakeup(struct tty_port *port) test_bit(SERPORT_ACTIVE, &serport->flags)) serdev_controller_write_wakeup(ctrl); - wake_up_interruptible_poll(&tty->write_wait, POLLOUT); + /* Wake up any tty_wait_until_sent() */ + wake_up_interruptible(&tty->write_wait); tty_kref_put(tty); } -- 2.15.0