* [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits
@ 2017-11-03 10:57 Mylène Josserand
2017-11-03 15:11 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Mylène Josserand @ 2017-11-03 10:57 UTC (permalink / raw)
To: maxime.ripard, wens, mturquette, sboyd
Cc: mylene.josserand, linux-arm-kernel, linux-clk, linux-kernel
i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
Because of that, the i2c0 (bit 0) was not correctly configured.
Fixed the correct bits for i2c1 and i2c2.
Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
---
drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
index e43acebdfbcd..f8203115a6bc 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
@@ -354,9 +354,9 @@ static SUNXI_CCU_GATE(bus_tdm_clk, "bus-tdm", "apb1",
static SUNXI_CCU_GATE(bus_i2c0_clk, "bus-i2c0", "apb2",
0x06c, BIT(0), 0);
static SUNXI_CCU_GATE(bus_i2c1_clk, "bus-i2c1", "apb2",
- 0x06c, BIT(0), 0);
+ 0x06c, BIT(1), 0);
static SUNXI_CCU_GATE(bus_i2c2_clk, "bus-i2c2", "apb2",
- 0x06c, BIT(0), 0);
+ 0x06c, BIT(2), 0);
static SUNXI_CCU_GATE(bus_uart0_clk, "bus-uart0", "apb2",
0x06c, BIT(16), 0);
static SUNXI_CCU_GATE(bus_uart1_clk, "bus-uart1", "apb2",
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits
2017-11-03 10:57 [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits Mylène Josserand
@ 2017-11-03 15:11 ` Stephen Boyd
2017-11-05 16:37 ` Mylene JOSSERAND
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2017-11-03 15:11 UTC (permalink / raw)
To: Mylène Josserand
Cc: maxime.ripard, wens, mturquette, linux-arm-kernel, linux-clk,
linux-kernel
On 11/03, Mylène Josserand wrote:
> i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> Because of that, the i2c0 (bit 0) was not correctly configured.
> Fixed the correct bits for i2c1 and i2c2.
>
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
> ---
Please add a Fixes tag.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits
2017-11-03 15:11 ` Stephen Boyd
@ 2017-11-05 16:37 ` Mylene JOSSERAND
0 siblings, 0 replies; 3+ messages in thread
From: Mylene JOSSERAND @ 2017-11-05 16:37 UTC (permalink / raw)
To: Stephen Boyd
Cc: maxime.ripard, wens, mturquette, linux-arm-kernel, linux-clk,
linux-kernel
Hello,
Le Fri, 3 Nov 2017 08:11:00 -0700,
Stephen Boyd <sboyd@codeaurora.org> a écrit :
> On 11/03, Mylène Josserand wrote:
> > i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> > Because of that, the i2c0 (bit 0) was not correctly configured.
> > Fixed the correct bits for i2c1 and i2c2.
> >
> > Signed-off-by: Mylène Josserand
> > <mylene.josserand@free-electrons.com> ---
>
> Please add a Fixes tag.
>
Sure, I will resend the patch with a Fixes tag.
Thank you,
--
Mylène Josserand, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-05 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 10:57 [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits Mylène Josserand
2017-11-03 15:11 ` Stephen Boyd
2017-11-05 16:37 ` Mylene JOSSERAND
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox