From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932450AbdKCQej (ORCPT ); Fri, 3 Nov 2017 12:34:39 -0400 Received: from gateway34.websitewelcome.com ([192.185.148.109]:24531 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbdKCQei (ORCPT ); Fri, 3 Nov 2017 12:34:38 -0400 Date: Fri, 3 Nov 2017 11:34:34 -0500 From: "Gustavo A. R. Silva" To: Sudeep Dutt , Ashutosh Dixit Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] misc: mic: scif_nodeqp: use swap macro in scif_node_connect Message-ID: <20171103163434.GA12906@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Source-L: No X-Exim-ID: 1eAevV-002fIn-Am X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:48924 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make use of the swap macro and remove unnecessary variable tmppayload. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/misc/mic/scif/scif_nodeqp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/misc/mic/scif/scif_nodeqp.c b/drivers/misc/mic/scif/scif_nodeqp.c index c66ca1a..e8ce4ba 100644 --- a/drivers/misc/mic/scif/scif_nodeqp.c +++ b/drivers/misc/mic/scif/scif_nodeqp.c @@ -467,7 +467,6 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst) struct list_head *pos, *tmp; struct scifmsg msg; int err; - u64 tmppayload; if (dst < 1 || dst > scif_info.maxid) return; @@ -524,9 +523,7 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst) msg.src.node = dev_i->node; msg.dst.node = dev_j->node; - tmppayload = msg.payload[0]; - msg.payload[0] = msg.payload[2]; - msg.payload[2] = tmppayload; + swap(msg.payload[0], msg.payload[2]); msg.payload[1] = p2p_ji->ppi_da[SCIF_PPI_MMIO]; msg.payload[3] = p2p_ji->ppi_len[SCIF_PPI_APER] << PAGE_SHIFT; -- 2.7.4