public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] cgroup: export list of delegatable control files using sysfs
Date: Fri, 3 Nov 2017 10:56:31 -0700	[thread overview]
Message-ID: <20171103175631.GV3252168@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171103174603.15249-1-guro@fb.com>

On Fri, Nov 03, 2017 at 01:46:02PM -0400, Roman Gushchin wrote:
> Delegatable cgroup v2 control files may require special handling
> (e.g. chowning), and the exact list of such files varies between
> kernel versions (and likely to be extended in the future).
> 
> To guarantee correctness of this list and simplify the life
> of userspace (systemd, first of all), let's export the list
> via /sys/kernel/cgroup/delegates pseudo-file.
> 
> Format is siple: each control file name is printed on a new line.
> Example:
>   $ cat /sys/kernel/cgroup/delegates

Generally looks good to me but I'm not sure whether "delegates" is the
right name for the file.  According to dictionary, it doesn't seem to
match too well to what we wanna mean here, which is "these files
belong to the child and should be transferred to the child when
delegating the cgroup".

Thanks.

-- 
tejun

  parent reply	other threads:[~2017-11-03 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 17:46 [PATCH 1/2] cgroup: export list of delegatable control files using sysfs Roman Gushchin
2017-11-03 17:46 ` [PATCH 2/2] cgroup: export list of cgroups v2 features " Roman Gushchin
2017-11-03 17:56 ` Tejun Heo [this message]
2017-11-06 17:38   ` [PATCH 1/2] cgroup: export list of delegatable control files " Tejun Heo
2017-11-06 18:30     ` [PATCH v2 " Roman Gushchin
2017-11-06 18:30       ` [PATCH v2 2/2] cgroup: export list of cgroups v2 features " Roman Gushchin
2017-11-06 20:02         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103175631.GV3252168@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=guro@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox