From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756314AbdKCR4k (ORCPT ); Fri, 3 Nov 2017 13:56:40 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:56375 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbdKCR4i (ORCPT ); Fri, 3 Nov 2017 13:56:38 -0400 X-Google-Smtp-Source: ABhQp+RBb3dhDsmR07IwkV+KoJNVB/BCmkAzTgikrr31roW4EccHMftNE6D7IJIMbrANZaliAUnn1A== Date: Fri, 3 Nov 2017 10:56:31 -0700 From: Tejun Heo To: Roman Gushchin Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] cgroup: export list of delegatable control files using sysfs Message-ID: <20171103175631.GV3252168@devbig577.frc2.facebook.com> References: <20171103174603.15249-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103174603.15249-1-guro@fb.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 01:46:02PM -0400, Roman Gushchin wrote: > Delegatable cgroup v2 control files may require special handling > (e.g. chowning), and the exact list of such files varies between > kernel versions (and likely to be extended in the future). > > To guarantee correctness of this list and simplify the life > of userspace (systemd, first of all), let's export the list > via /sys/kernel/cgroup/delegates pseudo-file. > > Format is siple: each control file name is printed on a new line. > Example: > $ cat /sys/kernel/cgroup/delegates Generally looks good to me but I'm not sure whether "delegates" is the right name for the file. According to dictionary, it doesn't seem to match too well to what we wanna mean here, which is "these files belong to the child and should be transferred to the child when delegating the cgroup". Thanks. -- tejun