From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932377AbdKDI0O (ORCPT <rfc822;w@1wt.eu>);
        Sat, 4 Nov 2017 04:26:14 -0400
Received: from mail-wr0-f173.google.com ([209.85.128.173]:56836 "EHLO
        mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752404AbdKDI0L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 4 Nov 2017 04:26:11 -0400
X-Google-Smtp-Source: ABhQp+Qwrr02H+RL4FRkkA5uCGbRqBG092O80mD2RjaKO/1Qj2/+/5JIyqWzkIjFpQ0EPgUtL0A2wQ==
Date: Sat, 4 Nov 2017 09:26:06 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, ricardo.neri@intel.com,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Qiaowei Ren <qiaowei.ren@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kees Cook <keescook@chromium.org>,
        Thomas Garnier <thgarnie@google.com>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in
 several utility functions
Message-ID: <20171104082606.u3ergfxu6sxtds4r@gmail.com>
References: <1509148310-30862-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <1509148310-30862-3-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <20171102085108.pgiem4kplrcmbzh6@gmail.com>
 <20171103024440.GA24896@voyager>
 <20171103101749.tukshf4rqgbhbcmu@gmail.com>
 <20171104004008.GA27257@voyager>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171104004008.GA27257@voyager>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:

> Plus, one more advantage of using char/short/int/long is that when building a 
> 32-bit kernel long will be a 32-bit type. Thus, all the aritmetic would be 
> naturally done with variables of the appropriate width. Perhaps I could use 
> u8/u16/u32/long? It looks white odd, though.

Ok, I agree that this aspect is important - and mixing u8/u16/u32 with 'long' 
would look a bit weird.

Let's keep the char/short/int/long types for now.

Thanks,

	Ingo